Make Conduit "www-form-urlencoded" parsing of "true" and "false" case-insensitive
ClosedPublic
Actions

Authored by epriestley on Apr 27 2020, 8:26 PM.

Details

Reviewers: None
Commits: rPc6054def2690: (stable) Make Conduit "www-form-urlencoded" parsing of "true" and "false" case…
rP661700536579: Make Conduit "www-form-urlencoded" parsing of "true" and "false" case…

Summary

See PHI1710. Python encodes True as True (with an uppercase "T") when building URLs.

We currently do not accept this as a "truthy" value, but it's reasonable and unambiguous. Accept "True", "TRUE", "tRuE", etc.

Test Plan

Made a cURL conduit call with "True" and "tRuE". Before patch: failure to decoded booleans; after patch: successful interpretation of "true" variations.

Diff Detail

Repository

rP Phabricator

Branch

normal1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24248
Build 33398: Run Core Tests
Build 33397: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 27 2020, 8:26 PM

Harbormaster completed remote builds in B24248: Diff 50429.Apr 27 2020, 8:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 27 2020, 8:28 PM

epriestley requested review of this revision.

Closed by commit rP661700536579: Make Conduit "www-form-urlencoded" parsing of "true" and "false" case… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP661700536579: Make Conduit "www-form-urlencoded" parsing of "true" and "false" case….

epriestley added a commit: rPc6054def2690: (stable) Make Conduit "www-form-urlencoded" parsing of "true" and "false" case….

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

parametertype/

ConduitParameterType.php

5 lines

Diff 50429

View Options

src/applications/conduit/parametertype/ConduitParameterType.php

Make Conduit "www-form-urlencoded" parsing of "true" and "false" case-insensitiveClosedPublicActions