Differential D21175

Fix a Diffusion issue where commits that do not show changesets would incorrectly try to render changesets
ClosedPublic
Actions

Authored by epriestley on Apr 27 2020, 5:34 PM.

Details

Reviewers: None
Commits: rPedfdf2c13066: (stable) Fix a Diffusion issue where commits that do not show changesets would…
rP604811bfc554: Fix a Diffusion issue where commits that do not show changesets would…

Summary

See https://discourse.phabricator-community.org/t/loading-certain-svn-commits-cause-unhandled-exception/3795/.

Commits with no changesets (for example, deleted commits) don't generate a "$changesets".

Test Plan

Viewed a commit with no changesets. Before change: exception. After change: saw unusual commit state.

Diff Detail

Repository

rP Phabricator

Branch

changeset1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24242
Build 33390: Run Core Tests
Build 33389: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 27 2020, 5:34 PM

Harbormaster completed remote builds in B24242: Diff 50423.Apr 27 2020, 5:36 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 27 2020, 5:36 PM

epriestley requested review of this revision.

Closed by commit rP604811bfc554: Fix a Diffusion issue where commits that do not show changesets would… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP604811bfc554: Fix a Diffusion issue where commits that do not show changesets would….

epriestley added a commit: rPedfdf2c13066: (stable) Fix a Diffusion issue where commits that do not show changesets would….

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionCommitController.php

5 lines

Diff 50423

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Fix a Diffusion issue where commits that do not show changesets would incorrectly try to render changesetsClosedPublicActions