Page MenuHomePhabricator
Differential D21173

Accommodate PHP 7.4 changes to certain "preg_match_all()" calls
ClosedPublic
Actions

Authored by epriestley on Apr 26 2020, 3:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 31, 9:00 PM
Unknown Object (File)
Mon, Dec 23, 7:29 AM
Unknown Object (File)
Mon, Dec 23, 2:40 AM
Unknown Object (File)
Fri, Dec 20, 9:16 PM
Unknown Object (File)
Wed, Dec 18, 4:16 AM
Unknown Object (File)
Tue, Dec 17, 6:40 AM
Unknown Object (File)
Tue, Dec 17, 5:56 AM
Unknown Object (File)
Tue, Dec 17, 5:06 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13518: PHP 7.4 "preg_match_all()" + "PREG_OFFSET_CAPTURE" behavior has changed
Commits
rARC5efbe22c2afa: (stable) Accommodate PHP 7.4 changes to certain "preg_match_all()" calls
rARCb81818b287db: Accommodate PHP 7.4 changes to certain "preg_match_all()" calls
Summary

Ref T13518. The result format of this call changed in PHP 7.4, which causes us to emit "-1" matches because "-1" survives array_filter().

Filter results in a way that should survive both result formats.

Test Plan

Ran arc unit --everything under PHP 7.4.

Diff Detail

Repository
rARC Arcanist
Branch
php741
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24237
Build 33383: Run Core Tests
Build 33382: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 26 2020, 3:32 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 26 2020, 3:32 PM
Harbormaster failed remote builds in B24233: Diff 50414!
epriestley updated this revision to Diff 50415.Apr 26 2020, 3:35 PM
  • Swap order to work better under PHP 7.3 and earlier.
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 26 2020, 3:35 PM
Harbormaster failed remote builds in B24234: Diff 50415!
epriestley updated this revision to Diff 50418.Apr 26 2020, 3:38 PM
  • Actually look at the PHP 7.3x output before writing code for it.
  • Third try's the charm!
Harbormaster completed remote builds in B24237: Diff 50418.Apr 26 2020, 3:39 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 26 2020, 3:39 PM
epriestley requested review of this revision.
Closed by commit rARCb81818b287db: Accommodate PHP 7.4 changes to certain "preg_match_all()" calls (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCb81818b287db: Accommodate PHP 7.4 changes to certain "preg_match_all()" calls.
epriestley added a commit: rARC5efbe22c2afa: (stable) Accommodate PHP 7.4 changes to certain "preg_match_all()" calls.

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
api/
21 lines

Diff 50418

View Options

src/parser/xhpast/api/XHPASTNode.php

Loading...
Phabricator · Built by Phacility