Page MenuHomePhabricator

Fix some PHP 7.4 array index access issues
ClosedPublic

Authored by epriestley on Apr 26 2020, 3:30 PM.
Tags
None
Referenced Files
F13256364: D21172.id.diff
Sat, May 25, 11:25 AM
F13249495: D21172.diff
Fri, May 24, 9:19 AM
F13229473: D21172.id.diff
Mon, May 20, 4:42 PM
F13218173: D21172.diff
Sat, May 18, 10:36 AM
F13200579: D21172.diff
Tue, May 14, 1:45 AM
Unknown Object (File)
Sun, May 5, 8:12 PM
Unknown Object (File)
Fri, May 3, 3:00 PM
Unknown Object (File)
Wed, May 1, 7:53 PM
Subscribers
None

Details

Summary

Ref T13518. See https://discourse.phabricator-community.org/t/more-exceptions-when-viewing-diffs/3789/. Under PHP 7.4, accessing an array index of values like false and null is no longer valid. This is great, but we occasionally do it.

Test Plan
  • Upgraded to PHP 7.4.
  • Loaded revisions with added/changed lines, inlines, and Asana support configured.
  • Before patch: saw various fatals around accessing indexes of booleans and nulls.
  • After patch: clean revision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 26 2020, 3:35 PM
This revision was automatically updated to reflect the committed changes.