Paths

Table of Contentst

Differential D21172

Fix some PHP 7.4 array index access issues
ClosedPublic
Actions

Authored by epriestley on Apr 26 2020, 3:30 PM.

Tags

None

Referenced Files

	F15460690: D21172.id50413.diff
	Tue, Apr 1, 1:15 AM

	F15457805: D21172.id.diff
	Sun, Mar 30, 7:08 PM

	F15456880: D21172.id50416.diff
	Sun, Mar 30, 12:48 PM

	F15455829: D21172.diff
	Sun, Mar 30, 5:07 AM

	F15449438: D21172.diff
	Fri, Mar 28, 10:16 AM

	F15396325: D21172.id.diff
	Sun, Mar 16, 1:30 PM

	F15395581: D21172.diff
	Sun, Mar 16, 8:11 AM

	F15315975: D21172.diff
	Mar 6 2025, 6:17 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13518: PHP 7.4 "preg_match_all()" + "PREG_OFFSET_CAPTURE" behavior has changed
Commits: rPfc018dfaadaf: (stable) Fix some PHP 7.4 array index access issues
rPb0c295e54509: Fix some PHP 7.4 array index access issues

Summary

Ref T13518. See https://discourse.phabricator-community.org/t/more-exceptions-when-viewing-diffs/3789/. Under PHP 7.4, accessing an array index of values like false and null is no longer valid. This is great, but we occasionally do it.

Test Plan

Upgraded to PHP 7.4.
Loaded revisions with added/changed lines, inlines, and Asana support configured.
Before patch: saw various fatals around accessing indexes of booleans and nulls.
After patch: clean revision.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 26 2020, 3:30 PM

Harbormaster completed remote builds in B24232: Diff 50413.Apr 26 2020, 3:31 PM

epriestley requested review of this revision.Apr 26 2020, 3:32 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 26 2020, 3:35 PM

Closed by commit rPb0c295e54509: Fix some PHP 7.4 array index access issues (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb0c295e54509: Fix some PHP 7.4 array index access issues.

epriestley added a commit: rPfc018dfaadaf: (stable) Fix some PHP 7.4 array index access issues.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialAsanaRepresentationField.php

4 lines

parser/

DifferentialChangesetParser.php

6 lines

render/

DifferentialChangesetTwoUpRenderer.php

5 lines

Diff 50416

src/applications/differential/customfield/DifferentialAsanaRepresentationField.php

Loading...

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...