Accommodate PHP 7.4 changes to certain "preg_match_all()" calls
ClosedPublic
Actions

Authored by epriestley on Apr 26 2020, 3:32 PM.

Details

Reviewers: None
Maniphest Tasks: T13518: PHP 7.4 "preg_match_all()" + "PREG_OFFSET_CAPTURE" behavior has changed
Commits: rARC5efbe22c2afa: (stable) Accommodate PHP 7.4 changes to certain "preg_match_all()" calls
rARCb81818b287db: Accommodate PHP 7.4 changes to certain "preg_match_all()" calls

Summary

Ref T13518. The result format of this call changed in PHP 7.4, which causes us to emit "-1" matches because "-1" survives array_filter().

Filter results in a way that should survive both result formats.

Test Plan

Ran arc unit --everything under PHP 7.4.

Repository

rARC Arcanist

Branch

php741

Lint

Lint Passed

Unit

Tests Passed

Build Status

	Time	Test
	13 ms	ArcanistDoubleQuoteXHPASTLinterRuleTestCase::testLinter Assertion failed, expected values to be equal (at ArcanistLinterTestCase.php:169): Some linters failed: - RuntimeException: Uninitialized string offset: 1
	13 ms	XHPASTNodeTestCase::testGetStringVariables EXCEPTION (RuntimeException): Uninitialized string offset: 1 #0 /core/data/drydock/workingcopy-88/repo/arcanist/src/parser/xhpast/api/XHPASTNode.php(172): PhutilErrorHandler::handleError(8, 'Uninitialized s...', '/core/data/dryd...', 172, Array) #1 /core/data/drydock/workingcopy-88/repo/arcanist/src/parser/xhpast/api/__tests__/XHPASTNodeTestCase.php(26): XHPASTNode->getStringVariables()
	1 ms	AbstractDirectedGraphTestCase::testCyclicGraph 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testEdgeLoadFailure 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testNonTreeGraph 1 assertion(s) passed.
		View Full Test Results (2 Failed · 541 Passed · 34 Skipped)