Differential D21171

Skip "null" lines when constructing raw documents for DocumentEngine rendering
ClosedPublic
Actions

Authored by epriestley on Apr 26 2020, 12:30 AM.

Tags

None

Referenced Files

	F15335746: D21171.diff
	Sat, Mar 8, 5:35 PM

	F15315974: D21171.id50410.diff
	Thu, Mar 6, 6:17 PM

	F15315972: D21171.id.diff
	Thu, Mar 6, 6:17 PM

	F15315970: D21171.diff
	Thu, Mar 6, 6:17 PM

	Unknown Object (File)
	Mon, Mar 3, 9:38 AM

	Unknown Object (File)
	Fri, Feb 21, 2:44 PM

	Unknown Object (File)
	Feb 3 2025, 12:35 AM

	Unknown Object (File)
	Jan 23 2025, 2:46 AM

Subscribers

None

Details

Reviewers: None
Commits: rPa1c978ef378a: (stable) Skip "null" lines when constructing raw documents for DocumentEngine…
rP7355bb7f2956: Skip "null" lines when constructing raw documents for DocumentEngine rendering

Summary

See https://discourse.phabricator-community.org/t/more-exceptions-when-viewing-diffs/3789. This is a similar issue with the same datastructure.

Test Plan

Works correctly under PHP 7.3, but this may not be the end of things.

Diff Detail

Repository

Branch

diff2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24229
Build 33371: Run Core Tests
Build 33370: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 26 2020, 12:30 AM

Harbormaster completed remote builds in B24229: Diff 50410.Apr 26 2020, 12:31 AM

epriestley requested review of this revision.Apr 26 2020, 12:31 AM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 26 2020, 12:34 AM

Closed by commit rP7355bb7f2956: Skip "null" lines when constructing raw documents for DocumentEngine rendering (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7355bb7f2956: Skip "null" lines when constructing raw documents for DocumentEngine rendering.

epriestley added a commit: rPa1c978ef378a: (stable) Skip "null" lines when constructing raw documents for DocumentEngine….

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

6 lines

Diff 50410

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...