Make the Ferret query compiler keep functions sticky across non-initial quoted tokens
ClosedPublic
Actions

Authored by epriestley on Apr 14 2020, 5:23 PM.

Details

Reviewers: None
Maniphest Tasks: T13509: Support "field present" and "field absent" operators in Ferret
Commits: rPb3a8754013cc: Make the Ferret query compiler keep functions sticky across non-initial quoted…

Summary

Ref T13509. In title:big "red" dog, keep "title" sticky across all three terms, since this seems like it's probably the best match for intent.

Test Plan

Added unit tests; ran unit tests.

Diff Detail

Repository

rP Phabricator

Branch

ferret6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24093
Build 33173: Run Core Tests
Build 33172: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 14 2020, 5:23 PM

Harbormaster completed remote builds in B24093: Diff 50275.Apr 14 2020, 5:24 PM

epriestley requested review of this revision.Apr 14 2020, 5:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 6:00 PM

Closed by commit rPb3a8754013cc: Make the Ferret query compiler keep functions sticky across non-initial quoted… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb3a8754013cc: Make the Ferret query compiler keep functions sticky across non-initial quoted….

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

compiler/

PhutilSearchQueryCompiler.php

9 lines

__tests__/

PhutilSearchQueryCompilerTestCase.php

8 lines

Diff 50275

View Options

src/applications/search/compiler/PhutilSearchQueryCompiler.php

View Options

src/applications/search/compiler/tests/PhutilSearchQueryCompilerTestCase.php

Make the Ferret query compiler keep functions sticky across non-initial quoted tokensClosedPublicActions