Page MenuHomePhabricator

Make Ferret query functions sticky only if their values are not quoted
ClosedPublic

Authored by epriestley on Apr 14 2020, 5:03 PM.
Tags
None
Referenced Files
F18805891: D21108.id50272.diff
Oct 18 2025, 4:54 PM
F18742090: D21108.diff
Oct 2 2025, 5:20 PM
F18702461: D21108.id50272.diff
Sep 28 2025, 12:14 AM
F18700976: D21108.id50279.diff
Sep 27 2025, 4:39 PM
F18697846: D21108.id.diff
Sep 27 2025, 10:30 AM
F18665742: D21108.id.diff
Sep 24 2025, 4:23 AM
F18659166: D21108.id50279.diff
Sep 23 2025, 10:15 AM
F18650211: D21108.diff
Sep 20 2025, 11:53 PM
Subscribers
None

Details

Summary

Ref T13509. Currently, functions are "sticky", but this stickness is in the query execution layer.

Instead:

  • move stickiness to the query compiler; and
  • make it so that functions are not sticky if their arguments are quoted.

For example:

  • title:x y previously meant title:x title:y (and still does). The "title:" is sticky.
  • title:"x" y previously meant title:x title:y. It now means title:x all:y. The "title:" is not sticky because the argument is quoted.
Test Plan

Added unit tests, ran unit tests.

Diff Detail

Repository
rP Phabricator
Branch
ferret3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24090
Build 33167: Run Core Tests
Build 33166: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 5:47 PM
This revision was automatically updated to reflect the committed changes.