Page MenuHomePhabricator

Make Ferret query functions sticky only if their values are not quoted
ClosedPublic

Authored by epriestley on Apr 14 2020, 5:03 PM.
Tags
None
Referenced Files
F14895148: D21108.id50279.diff
Sun, Feb 9, 8:57 AM
F14895147: D21108.id50272.diff
Sun, Feb 9, 8:57 AM
F14895146: D21108.id.diff
Sun, Feb 9, 8:57 AM
F14895145: D21108.diff
Sun, Feb 9, 8:57 AM
Unknown Object (File)
Thu, Feb 6, 11:58 AM
Unknown Object (File)
Sat, Jan 25, 7:03 AM
Unknown Object (File)
Sat, Jan 25, 7:03 AM
Unknown Object (File)
Sat, Jan 25, 7:03 AM
Subscribers
None

Details

Summary

Ref T13509. Currently, functions are "sticky", but this stickness is in the query execution layer.

Instead:

  • move stickiness to the query compiler; and
  • make it so that functions are not sticky if their arguments are quoted.

For example:

  • title:x y previously meant title:x title:y (and still does). The "title:" is sticky.
  • title:"x" y previously meant title:x title:y. It now means title:x all:y. The "title:" is not sticky because the argument is quoted.
Test Plan

Added unit tests, ran unit tests.

Diff Detail

Repository
rP Phabricator
Branch
ferret3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24090
Build 33167: Run Core Tests
Build 33166: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 5:47 PM
This revision was automatically updated to reflect the committed changes.