Add "absent" and "present" field operators to the Ferret query compiler
ClosedPublic
Actions

Authored by epriestley on Apr 14 2020, 4:56 PM.

Details

Reviewers: None
Maniphest Tasks: T13509: Support "field present" and "field absent" operators in Ferret
Commits: rPf31b9987ba1b: Add "absent" and "present" field operators to the Ferret query compiler

Summary

Ref T13509. Parse "xyz:-" as "xyz is absent" and "xyz:~" as "xyz is present". These are new operators which the compiler emits separately from "not" and "substring".

Test Plan

Added unit tests, ran unit tests.

Diff Detail

Repository

rP Phabricator

Branch

ferret2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24089
Build 33165: Run Core Tests
Build 33164: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 14 2020, 4:56 PM

Harbormaster completed remote builds in B24089: Diff 50271.Apr 14 2020, 4:57 PM

epriestley requested review of this revision.Apr 14 2020, 4:57 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 5:47 PM

Closed by commit rPf31b9987ba1b: Add "absent" and "present" field operators to the Ferret query compiler (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf31b9987ba1b: Add "absent" and "present" field operators to the Ferret query compiler.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

compiler/

PhutilSearchQueryCompiler.php

18 lines

__tests__/

PhutilSearchQueryCompilerTestCase.php

14 lines

Diff 50271

View Options

src/applications/search/compiler/PhutilSearchQueryCompiler.php

View Options

src/applications/search/compiler/tests/PhutilSearchQueryCompilerTestCase.php

Add "absent" and "present" field operators to the Ferret query compilerClosedPublicActions