Tighten Ferret query parsing of empty tokens and empty functions
ClosedPublic
Actions

Authored by epriestley on Apr 14 2020, 4:51 PM.

Details

Reviewers: None
Maniphest Tasks: T13509: Support "field present" and "field absent" operators in Ferret
Commits: rP5c30a60e305f: Tighten Ferret query parsing of empty tokens and empty functions

Summary

Ref T13509. Certain query tokens like title:="" are currently accepted by the parser but discarded, and have no impact on the query. This isn't desirable.

Instead, require that tokens making an assertion about field content must be nonempty.

Test Plan

Added unit tests, made them pass.

Diff Detail

Repository

rP Phabricator

Branch

ferret1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24088
Build 33163: Run Core Tests
Build 33162: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 14 2020, 4:51 PM

Harbormaster completed remote builds in B24088: Diff 50270.Apr 14 2020, 4:53 PM

epriestley requested review of this revision.Apr 14 2020, 4:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 5:32 PM

Closed by commit rP5c30a60e305f: Tighten Ferret query parsing of empty tokens and empty functions (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5c30a60e305f: Tighten Ferret query parsing of empty tokens and empty functions.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

compiler/

PhutilSearchQueryCompiler.php

69 lines

__tests__/

PhutilSearchQueryCompilerTestCase.php

31 lines

Diff 50270

View Options

src/applications/search/compiler/PhutilSearchQueryCompiler.php

View Options

src/applications/search/compiler/tests/PhutilSearchQueryCompilerTestCase.php

Tighten Ferret query parsing of empty tokens and empty functionsClosedPublicActions