Differential D21103

Fix an issue where raw diffs that are not attached to revisions could skip repository policy checks
ClosedPublic
Actions

Authored by epriestley on Apr 13 2020, 7:05 PM.

Tags

None

Referenced Files

	F13239524: D21103.diff
	Wed, May 22, 4:15 AM

	F13216848: D21103.diff
	Sat, May 18, 2:37 AM

	F13200016: D21103.id.diff
	Mon, May 13, 9:00 PM

	F13198836: D21103.diff
	Mon, May 13, 10:09 AM

	F13191700: D21103.id50262.diff
	Sat, May 11, 11:13 PM

	F13184353: D21103.id50264.diff
	Fri, May 10, 6:01 PM

	F13181349: D21103.diff
	Thu, May 9, 11:52 AM

	Unknown Object (File)
	Wed, May 1, 1:50 PM

View All 56 Files

Subscribers

None

Details

Reviewers: None
Commits: rP3f9609a55cb5: (stable) Fix an issue where raw diffs that are not attached to revisions could…
rP19e0abcb27b4: Fix an issue where raw diffs that are not attached to revisions could skip…

Summary

See PHI1697. If a diff is not attached to a revision (for example, if it was created with "arc diff --only"), but is attached to a repository, it is supposed to be visible only to users who can see that repository.

It currently skips this extended policy check and may incorrectly be visible to too many users.

(Once a diff is attached to a revision, this rule is enforced properly via the revision policy.)

Test Plan

Set repository R to be visible only to Alice.
As Alice, created a diff from a working copy of repository R with "arc diff --only".
As Bailey, viewed the diff.
- Before: visible diff.
- After: policy exception (as expected).

Diff Detail

Repository

Branch

uri2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24080
Build 33152: Run Core Tests
Build 33151: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 13 2020, 7:05 PM

Harbormaster completed remote builds in B24080: Diff 50262.Apr 13 2020, 7:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 13 2020, 7:07 PM

epriestley requested review of this revision.

Closed by commit rP19e0abcb27b4: Fix an issue where raw diffs that are not attached to revisions could skip… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP19e0abcb27b4: Fix an issue where raw diffs that are not attached to revisions could skip….

epriestley added a commit: rP3f9609a55cb5: (stable) Fix an issue where raw diffs that are not attached to revisions could….

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialDiff.php

5 lines

Diff 50262

src/applications/differential/storage/DifferentialDiff.php

Loading...