Paths

Table of Contentst

Differential D21061

Update DivinerAtomController for a long-ago change to the docblock parser API
ClosedPublic
Actions

Authored by epriestley on Apr 6 2020, 6:21 PM.

Tags

None

Referenced Files

	F15462577: D21061.id50179.diff
	Tue, Apr 1, 4:05 PM

	F15461928: D21061.id50178.diff
	Tue, Apr 1, 12:23 PM

	F15459831: D21061.diff
	Mon, Mar 31, 5:24 PM

	F15459810: D21061.id.diff
	Mon, Mar 31, 4:47 PM

	F15455926: D21061.diff
	Sun, Mar 30, 5:45 AM

	F15423034: D21061.diff
	Sat, Mar 22, 12:19 PM

	F15413884: D21061.diff
	Wed, Mar 19, 9:48 PM

	F15382112: D21061.diff
	Fri, Mar 14, 10:43 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given"
Commits: rP271e104c7ea4: Update DivinerAtomController for a long-ago change to the docblock parser API

Summary

Ref T13505. See that task for discussion.

Test Plan

Ran diviner generate locally, found a page fataling on this strlen(), applied patch, got a sketchy but not-broken page.

Diff Detail

Repository

Branch

diviner1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23997
Build 33026: Run Core Tests
Build 33025: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 6 2020, 6:21 PM

Harbormaster completed remote builds in B23997: Diff 50178.Apr 6 2020, 6:22 PM

epriestley requested review of this revision.Apr 6 2020, 6:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 6 2020, 6:31 PM

Closed by commit rP271e104c7ea4: Update DivinerAtomController for a long-ago change to the docblock parser API (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP271e104c7ea4: Update DivinerAtomController for a long-ago change to the docblock parser API.

epriestley mentioned this in T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".Apr 6 2020, 6:45 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

controller/

DivinerAtomController.php

4 lines

Diff 50178

src/applications/diviner/controller/DivinerAtomController.php

Loading...