Page MenuHomePhabricator
Differential D21058

Move Phage to FuturePool
ClosedPublic
Actions

Authored by epriestley on Apr 5 2020, 12:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 2:48 PM
Unknown Object (File)
Mon, Apr 8, 6:42 PM
Unknown Object (File)
Sat, Mar 30, 9:10 AM
Unknown Object (File)
Fri, Mar 29, 4:43 AM
Unknown Object (File)
Tue, Mar 26, 7:49 AM
Unknown Object (File)
Feb 20 2024, 9:40 PM
Unknown Object (File)
Feb 13 2024, 6:13 AM
Unknown Object (File)
Feb 3 2024, 11:54 PM
View All 80 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T11968: Decide the fate of FutureGraph
Commits
rARC32005f26a4e7: Move Phage to FuturePool
Summary

Ref T11968. Phage has another "sustained pool of Futures" use case, and needs some slight adjustments after Future API changes.

Test Plan

Ran bin/phage status ..., got a clean result instead of a JSON decoding failure.

Diff Detail

Repository
rARC Arcanist
Branch
pfuture1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23989
Build 33015: Run Core Tests
Build 33014: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 5 2020, 12:50 PM
epriestley edited the test plan for this revision. (Show Details)Apr 5 2020, 12:51 PM
Harbormaster completed remote builds in B23989: Diff 50170.Apr 5 2020, 12:51 PM
epriestley requested review of this revision.Apr 5 2020, 12:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2020, 12:56 PM
Closed by commit rARC32005f26a4e7: Move Phage to FuturePool (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC32005f26a4e7: Move Phage to FuturePool.

Revision Contents
Changeset List

PathSize
src/
channel/
26 lines
filesystem/
2 lines
future/
4 lines
phage/
agent/
55 lines
bootloader/
1 line
utils/
4 lines

Diff 50170

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/channel/PhutilJSONProtocolChannel.php

Loading...
View Options

src/filesystem/PhutilDeferredLog.php

Loading...
View Options

src/future/FuturePool.php

Loading...
View Options

src/phage/agent/PhagePHPAgent.php

Loading...
View Options

src/phage/bootloader/PhagePHPAgentBootloader.php

Loading...
View Options

src/utils/utils.php

Loading...
Phabricator · Built by Phacility