Fix two issues with Future key selection inside FutureIterator
ClosedPublic
Actions

Authored by epriestley on Apr 1 2020, 5:33 PM.

Tags

None

Referenced Files

	F15395263: D21046.id50145.diff
	Sun, Mar 16, 4:25 AM

	F15380807: D21046.id50145.diff
	Fri, Mar 14, 4:32 AM

	F15329994: D21046.diff
	Fri, Mar 7, 7:13 AM

	Unknown Object (File)
	Sun, Mar 2, 11:27 PM

	Unknown Object (File)
	Sun, Mar 2, 1:38 PM

	Unknown Object (File)
	Wed, Feb 26, 3:25 AM

	Unknown Object (File)
	Feb 16 2025, 12:13 PM

	Unknown Object (File)
	Feb 13 2025, 7:37 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T11968: Decide the fate of FutureGraph
Commits: rARC492113370aa8: Fix two issues with Future key selection inside FutureIterator

Summary

Ref T11968.

Rekeying natural lists of futures creates more problems than it solves. For now, don't try to deal with this.
The scope of the future autokey was incorrect (per subclass, not per process).

Test Plan

Ran various future-oriented flows on new HardpointEngine code.

Diff Detail

Repository

rARC Arcanist

Branch

future1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23963
Build 32975: Run Core Tests
Build 32974: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 1 2020, 5:33 PM

Harbormaster completed remote builds in B23963: Diff 50144.Apr 1 2020, 5:34 PM

epriestley requested review of this revision.Apr 1 2020, 5:34 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2020, 5:36 PM

Closed by commit rARC492113370aa8: Fix two issues with Future key selection inside FutureIterator (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC492113370aa8: Fix two issues with Future key selection inside FutureIterator.

Revision Contents
Changeset List

Path

Size

src/

future/

Future.php

5 lines

FutureIterator.php

6 lines

Diff 50144

View Options

src/future/Future.php