Page MenuHomePhabricator

Fix two issues with Future key selection inside FutureIterator
ClosedPublic

Authored by epriestley on Apr 1 2020, 5:33 PM.
Tags
None
Referenced Files
F15395263: D21046.id50145.diff
Sun, Mar 16, 4:25 AM
F15380807: D21046.id50145.diff
Fri, Mar 14, 4:32 AM
F15329994: D21046.diff
Fri, Mar 7, 7:13 AM
Unknown Object (File)
Sun, Mar 2, 11:27 PM
Unknown Object (File)
Sun, Mar 2, 1:38 PM
Unknown Object (File)
Wed, Feb 26, 3:25 AM
Unknown Object (File)
Feb 16 2025, 12:13 PM
Unknown Object (File)
Feb 13 2025, 7:37 AM
Subscribers
None

Details

Summary

Ref T11968.

  • Rekeying natural lists of futures creates more problems than it solves. For now, don't try to deal with this.
  • The scope of the future autokey was incorrect (per subclass, not per process).
Test Plan

Ran various future-oriented flows on new HardpointEngine code.

Diff Detail

Repository
rARC Arcanist
Branch
future1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23963
Build 32975: Run Core Tests
Build 32974: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2020, 5:36 PM
This revision was automatically updated to reflect the committed changes.