Page MenuHomePhabricator
Differential D20984

Make "arcanist/" unit tests pass
ClosedPublic
Actions

Authored by epriestley on Feb 12 2020, 11:58 PM.
Tags
None
Referenced Files
F19819474: D20984.id.diff
Fri, Mar 6, 6:41 AM
F19787442: D20984.id.diff
Wed, Feb 25, 1:42 PM
F19787324: D20984.id.diff
Wed, Feb 25, 1:34 PM
F19618331: D20984.diff
Feb 4 2026, 8:02 AM
F19615224: D20984.diff
Feb 3 2026, 11:31 PM
F19526520: D20984.diff
Jan 18 2026, 5:48 PM
F19526500: D20984.diff
Jan 18 2026, 5:45 PM
F19526460: D20984.diff
Jan 18 2026, 5:12 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13395: Strip libphutil for parts
Commits
rARCa8a50b2fc004: Make "arcanist/" unit tests pass
Summary

Ref T13395. Fixes a file-locking test and removes a logging test that's more trouble than it's worth.

Test Plan

Ran "arc unit --everything" locally, got a clean bill of health.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 12 2020, 11:58 PM
Harbormaster completed remote builds in B23826: Diff 50000.Feb 12 2020, 11:59 PM
epriestley requested review of this revision.Feb 12 2020, 11:59 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2020, 12:20 AM
Closed by commit rARCa8a50b2fc004: Make "arcanist/" unit tests pass (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCa8a50b2fc004: Make "arcanist/" unit tests pass.

Revision Contents
Changeset List

PathSize
src/
filesystem/
__tests__/
22 lines
6 lines
support/
test/
82 lines

Diff 50001

View Options

src/filesystem/__tests__/PhutilDeferredLogTestCase.php

Loading...
View Options

src/filesystem/__tests__/PhutilFileLockTestCase.php

Loading...
View Options

support/test/lock-file.php

Loading...
Phabricator · Built by Phacility