Differential D20983

Unprototype "Draft" mode in Differential
ClosedPublic
Actions

Authored by epriestley on Feb 12 2020, 11:48 PM.

Details

Reviewers: None
Maniphest Tasks: T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
Commits: rPdc35ce79e484: Unprototype "Draft" mode in Differential

Summary

Fixes T2543. This mode has been a stable prototype for a very long time now; promote it so "--draft" can promote out of "experimental" in Arcanist.

Test Plan

See T2543 for discussion.

Diff Detail

Repository

rP Phabricator

Branch

draft1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23824
Build 32770: Run Core Tests
Build 32769: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 12 2020, 11:48 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2020, 11:48 PM

Harbormaster failed remote builds in B23824: Diff 49998!

Harbormaster completed remote builds in B23824: Diff 49998.Feb 12 2020, 11:52 PM

epriestley requested review of this revision.Feb 12 2020, 11:52 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2020, 12:20 AM

Closed by commit rPdc35ce79e484: Unprototype "Draft" mode in Differential (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPdc35ce79e484: Unprototype "Draft" mode in Differential.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialRevision.php

9 lines

Diff 49998

View Options

src/applications/differential/storage/DifferentialRevision.php

Unprototype "Draft" mode in DifferentialClosedPublicActions