Ref T13395. Currently, "phage" is required for various cluster operations. Bring the working code out of "experimental". This isn't the final form; "wilds" has a fancier version.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13395: Strip libphutil for parts
- Commits
- rARC61e059984a15: Merge "phage" from "experimental"
Ran phage workflows against the cluster.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- master
- Lint
Lint Passed Severity Location Code Message Advice scripts/phage.php:13 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 23823 Build 32768: Run Core Tests Build 32767: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 12 ms | PhutilDeferredLogTestCase::testManyWriters Assertion failed, expected values to be equal (at PhutilDeferredLogTestCase.php:116).
Expected vs Actual Output Diff
--- Old Value
| |
| 22 ms | PhutilFileLockTestCase::testInProcessHolding EXCEPTION (Exception): Unable to hold lock in external process!
#0 /core/data/drydock/workingcopy-88/repo/arcanist/src/filesystem/__tests__/PhutilFileLockTestCase.php(51): PhutilFileLockTestCase->holdLock(Object(TempFile))
#1 [internal function]: PhutilFileLockTestCase->testInProcessHolding()
| |
| 30 ms | PhutilFileLockTestCase::testInProcessLocking Assertion failed, expected 'true' (at PhutilFileLockTestCase.php:41).
ACTUAL VALUE
| |
| 22 ms | PhutilFileLockTestCase::testLockHolding EXCEPTION (Exception): Unable to hold lock in external process!
#0 /core/data/drydock/workingcopy-88/repo/arcanist/src/filesystem/__tests__/PhutilFileLockTestCase.php(20): PhutilFileLockTestCase->holdLock(Object(TempFile))
#1 [internal function]: PhutilFileLockTestCase->testLockHolding()
| |
| 15 ms | PhutilFileLockTestCase::testLockTesting Assertion failed, expected 'true' (at PhutilFileLockTestCase.php:10).
ACTUAL VALUE
| |
| View Full Test Results (6 Failed · 470 Passed · 36 Skipped) |