Differential D20981

Merge a small amount of remaining "libphutil/" code with Phabricator, break libphutil dependency
ClosedPublic
Actions

Authored by epriestley on Feb 12 2020, 11:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 8:38 AM

	Unknown Object (File)
	Sun, Feb 9, 8:38 AM

	Unknown Object (File)
	Sun, Feb 9, 8:38 AM

	Unknown Object (File)
	Sun, Feb 9, 8:38 AM

	Unknown Object (File)
	Tue, Jan 28, 5:26 AM

	Unknown Object (File)
	Sat, Jan 25, 6:30 AM

	Unknown Object (File)
	Sat, Jan 25, 6:30 AM

	Unknown Object (File)
	Sat, Jan 25, 6:30 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13395: Strip libphutil for parts
Commits: rP35a18146a28f: Merge a small amount of remaining "libphutil/" code with Phabricator, break…

Summary

Ref T13395. Moves a small amount of remaining "libphutil/" code into "phabricator/" and stops us from loading "libphutil/".

Test Plan

Browsed around; there are likely remaining issues.

Diff Detail

Repository

Branch

split5

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/infrastructure/daemon/PhutilDaemonOverseer.php:126	XHP16	TODO Comment
Advice	src/infrastructure/daemon/PhutilDaemonOverseer.php:210	XHP16	TODO Comment
Advice	src/infrastructure/daemon/PhutilDaemonPool.php:78	XHP16	TODO Comment
Advice	src/infrastructure/daemon/PhutilDaemonPool.php:248	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 23819
Build 32763: Run Core Tests
Build 32762: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 12 2020, 11:11 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2020, 11:12 PM

Harbormaster failed remote builds in B23818: Diff 49992!

Adjustments to daemons.

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2020, 11:15 PM

Harbormaster failed remote builds in B23819: Diff 49993!

Depends on harness changes to even plausibly build.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2020, 11:17 PM

This revision was landed with ongoing or failed builds.

Closed by commit rP35a18146a28f: Merge a small amount of remaining "libphutil/" code with Phabricator, break… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP35a18146a28f: Merge a small amount of remaining "libphutil/" code with Phabricator, break….

Revision Contents
Changeset List

Path

Size

externals/

cldr/

cldr_windows_timezones.xml

769 lines

resources/

timezones/

generate-timezone-map.php

46 lines

windows-timezones.json

126 lines

scripts/

daemon/

exec/

exec_daemon.php

131 lines

init/

12 lines

src/

__phutil_library_map__.php

applications/

calendar/

parser/

ics/

PhutilICSParser.php

4 lines

infrastructure/

daemon/

PhutilDaemon.php

393 lines

PhutilDaemonHandle.php

506 lines

PhutilDaemonOverseer.php

405 lines

PhutilDaemonOverseerModule.php

71 lines

PhutilDaemonPool.php

360 lines

view/

widget/

AphrontStackTraceView.php

1 line

support/

startup/

PhabricatorStartup.php

11 lines

Diff 49993

externals/cldr/cldr_windows_timezones.xml

Loading...

resources/timezones/generate-timezone-map.php

Loading...

resources/timezones/windows-timezones.json

Loading...

scripts/daemon/exec/exec_daemon.php

Loading...

scripts/init/lib.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/calendar/parser/ics/PhutilICSParser.php

Loading...

src/infrastructure/daemon/PhutilDaemon.php

Loading...

src/infrastructure/daemon/PhutilDaemonHandle.php

Loading...

src/infrastructure/daemon/PhutilDaemonOverseer.php

Loading...

src/infrastructure/daemon/PhutilDaemonOverseerModule.php

Loading...

src/infrastructure/daemon/PhutilDaemonPool.php

Loading...

src/view/widget/AphrontStackTraceView.php

Loading...

support/startup/PhabricatorStartup.php

Loading...