Differential D20976

Move additional classes out of libphutil, to Phabricator
ClosedPublic
Actions

Authored by epriestley on Feb 12 2020, 7:58 PM.

Details

Reviewers: None
Maniphest Tasks: T13395: Strip libphutil for parts
Commits: rPHUce63d5b45049: Move additional classes out of libphutil, to Phabricator

Summary

Ref T13395. Continue moving classes with no identifiable callsites in libphutil or Arcanist to Phabricator.

Test Plan

Searched for any callers in libphutil or Arcanist, didn't find any.

Diff Detail

Repository

rPHU libphutil

Branch

strip2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23810
Build 32748: Run Core Tests
Build 32747: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 12 2020, 7:58 PM

Herald added a subscriber: Firehed. · View Herald TranscriptFeb 12 2020, 7:58 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2020, 7:59 PM

Harbormaster failed remote builds in B23805: Diff 49979!

Also move the "PygmentizeParser", which needs HTML rendering functions.

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2020, 8:08 PM

Harbormaster failed remote builds in B23808: Diff 49982!

Separate and move a "pht()" -> "hsprintf()" dependency and some related code which has HTML cases.

Harbormaster completed remote builds in B23810: Diff 49984.Feb 12 2020, 8:29 PM

epriestley requested review of this revision.Feb 12 2020, 8:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2020, 9:13 PM

Closed by commit rPHUce63d5b45049: Move additional classes out of libphutil, to Phabricator (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPHUce63d5b45049: Move additional classes out of libphutil, to Phabricator.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

cache/

PhutilAPCKeyValueCache.php

PhutilDirectoryKeyValueCache.php

PhutilInRequestKeyValueCache.php

PhutilKeyValueCache.php

PhutilKeyValueCacheNamespace.php

PhutilKeyValueCacheProfiler.php

PhutilKeyValueCacheProxy.php

PhutilKeyValueCacheStack.php

PhutilMemcacheKeyValueCache.php

PhutilOnDiskKeyValueCache.php

__tests__/

PhutilKeyValueCacheTestCase.php

grammar/

PhutilContextFreeGrammar.php

internationalization/

PhutilTranslator.php

6 lines

__tests__/

PhutilTranslatorTestCase.php

61 lines

markup/

PhutilMarkupEngine.php

PhutilSafeHTML.php

PhutilSafeHTMLProducerInterface.php

__tests__/

PhutilMarkupTestCase.php

PhutilSafeHTMLTestCase.php

render.php

syntax/

engine/

PhutilDefaultSyntaxHighlighterEngine.php

PhutilSyntaxHighlighterEngine.php

__tests__/

PhutilDefaultSyntaxHighlighterEngineTestCase.php

highlighter/

PhutilConsoleSyntaxHighlighter.php

PhutilDefaultSyntaxHighlighter.php

PhutilDivinerSyntaxHighlighter.php

PhutilInvisibleSyntaxHighlighter.php

PhutilLexerSyntaxHighlighter.php

PhutilPygmentsSyntaxHighlighter.php

PhutilRainbowSyntaxHighlighter.php

PhutilSyntaxHighlighter.php

PhutilSyntaxHighlighterException.php

PhutilXHPASTSyntaxHighlighter.php

__tests__/

PhutilJSONFragmentLexerHighlighterTestCase.php

PhutilPHPFragmentLexerHighlighterTestCase.php

PhutilXHPASTSyntaxHighlighterTestCase.php

data/

jsonfragment/

phpfragment/

leading-whitespace.expect

leading-whitespace.test

no-leading-whitespace.expect

no-leading-whitespace.test

xhpast/

builtin-classname.expect

builtin-classname.source

leading-whitespace.expect

leading-whitespace.source

multiline-token.expect

multiline-token.source

no-leading-whitespace.expect

no-leading-whitespace.source

trailing-comment.expect

trailing-comment.source

pygments/

PhutilDefaultSyntaxHighlighterEnginePygmentsFuture.php

xhpast/

PhutilXHPASTSyntaxHighlighterFuture.php

parser/

PhutilPygmentizeParser.php

__tests__/

PhutilPygmentizeParserTestCase.php

sprites/

PhutilSprite.php

PhutilSpriteSheet.php

utils/

utils.php

77 lines

Diff 49984

View Options

src/__phutil_library_map__.php

View Options

src/cache/PhutilAPCKeyValueCache.php

View Options

src/cache/PhutilDirectoryKeyValueCache.php

View Options

src/cache/PhutilInRequestKeyValueCache.php

View Options

src/cache/PhutilKeyValueCache.php

View Options

src/cache/PhutilKeyValueCacheNamespace.php

View Options

src/cache/PhutilKeyValueCacheProfiler.php

View Options

src/cache/PhutilKeyValueCacheProxy.php

View Options

src/cache/PhutilKeyValueCacheStack.php

View Options

src/cache/PhutilMemcacheKeyValueCache.php

View Options

src/cache/PhutilOnDiskKeyValueCache.php

View Options

src/cache/tests/PhutilKeyValueCacheTestCase.php

View Options

src/grammar/PhutilContextFreeGrammar.php

View Options

src/internationalization/PhutilTranslator.php

View Options

src/internationalization/tests/PhutilTranslatorTestCase.php

View Options

src/markup/PhutilMarkupEngine.php

View Options

src/markup/PhutilSafeHTML.php

View Options

src/markup/PhutilSafeHTMLProducerInterface.php

View Options

src/markup/tests/PhutilMarkupTestCase.php

View Options

src/markup/tests/PhutilSafeHTMLTestCase.php

View Options

src/markup/render.php

View Options

src/markup/syntax/engine/PhutilDefaultSyntaxHighlighterEngine.php

View Options

src/markup/syntax/engine/PhutilSyntaxHighlighterEngine.php

View Options

src/markup/syntax/engine/tests/PhutilDefaultSyntaxHighlighterEngineTestCase.php

View Options

src/markup/syntax/highlighter/PhutilConsoleSyntaxHighlighter.php

View Options

src/markup/syntax/highlighter/PhutilDefaultSyntaxHighlighter.php

View Options

src/markup/syntax/highlighter/PhutilDivinerSyntaxHighlighter.php

View Options

src/markup/syntax/highlighter/PhutilInvisibleSyntaxHighlighter.php

View Options

src/markup/syntax/highlighter/PhutilLexerSyntaxHighlighter.php

View Options

src/markup/syntax/highlighter/PhutilPygmentsSyntaxHighlighter.php

View Options

src/markup/syntax/highlighter/PhutilRainbowSyntaxHighlighter.php

View Options

src/markup/syntax/highlighter/PhutilSyntaxHighlighter.php

View Options

src/markup/syntax/highlighter/PhutilSyntaxHighlighterException.php

View Options

src/markup/syntax/highlighter/PhutilXHPASTSyntaxHighlighter.php

View Options

src/markup/syntax/highlighter/tests/PhutilJSONFragmentLexerHighlighterTestCase.php

View Options

src/markup/syntax/highlighter/tests/PhutilPHPFragmentLexerHighlighterTestCase.php

View Options

src/markup/syntax/highlighter/tests/PhutilXHPASTSyntaxHighlighterTestCase.php

View Options

src/markup/syntax/highlighter/tests/data/jsonfragment/basics.expect

View Options

src/markup/syntax/highlighter/tests/data/jsonfragment/basics.test

View Options

src/markup/syntax/highlighter/tests/phpfragment/abuse.expect

View Options

src/markup/syntax/highlighter/tests/phpfragment/abuse.test

View Options

src/markup/syntax/highlighter/tests/phpfragment/basics.expect

View Options

src/markup/syntax/highlighter/tests/phpfragment/basics.test

View Options

src/markup/syntax/highlighter/tests/phpfragment/leading-whitespace.expect

View Options

src/markup/syntax/highlighter/tests/phpfragment/leading-whitespace.test

View Options

src/markup/syntax/highlighter/tests/phpfragment/no-leading-whitespace.expect

View Options

src/markup/syntax/highlighter/tests/phpfragment/no-leading-whitespace.test

View Options

src/markup/syntax/highlighter/tests/xhpast/builtin-classname.expect

View Options

src/markup/syntax/highlighter/tests/xhpast/builtin-classname.source

View Options

src/markup/syntax/highlighter/tests/xhpast/leading-whitespace.expect

View Options

src/markup/syntax/highlighter/tests/xhpast/leading-whitespace.source

View Options

src/markup/syntax/highlighter/tests/xhpast/multiline-token.expect

View Options

src/markup/syntax/highlighter/tests/xhpast/multiline-token.source

View Options

src/markup/syntax/highlighter/tests/xhpast/no-leading-whitespace.expect

View Options

src/markup/syntax/highlighter/tests/xhpast/no-leading-whitespace.source

View Options

src/markup/syntax/highlighter/tests/xhpast/trailing-comment.expect

View Options

src/markup/syntax/highlighter/tests/xhpast/trailing-comment.source

View Options

src/markup/syntax/highlighter/pygments/PhutilDefaultSyntaxHighlighterEnginePygmentsFuture.php

View Options

src/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php

View Options

src/parser/PhutilPygmentizeParser.php

View Options

src/parser/tests/PhutilPygmentizeParserTestCase.php

View Options

src/sprites/PhutilSprite.php

View Options

src/sprites/PhutilSpriteSheet.php

View Options

Move additional classes out of libphutil, to PhabricatorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49984

src/__phutil_library_map__.php

src/cache/PhutilAPCKeyValueCache.php

src/cache/PhutilDirectoryKeyValueCache.php

src/cache/PhutilInRequestKeyValueCache.php

src/cache/PhutilKeyValueCache.php

src/cache/PhutilKeyValueCacheNamespace.php

src/cache/PhutilKeyValueCacheProfiler.php

src/cache/PhutilKeyValueCacheProxy.php

src/cache/PhutilKeyValueCacheStack.php

src/cache/PhutilMemcacheKeyValueCache.php

src/cache/PhutilOnDiskKeyValueCache.php

src/cache/__tests__/PhutilKeyValueCacheTestCase.php

src/grammar/PhutilContextFreeGrammar.php

src/internationalization/PhutilTranslator.php

src/internationalization/__tests__/PhutilTranslatorTestCase.php

src/markup/PhutilMarkupEngine.php

src/markup/PhutilSafeHTML.php

src/markup/PhutilSafeHTMLProducerInterface.php

src/markup/__tests__/PhutilMarkupTestCase.php

src/markup/__tests__/PhutilSafeHTMLTestCase.php

src/markup/render.php

src/markup/syntax/engine/PhutilDefaultSyntaxHighlighterEngine.php

src/markup/syntax/engine/PhutilSyntaxHighlighterEngine.php

src/markup/syntax/engine/__tests__/PhutilDefaultSyntaxHighlighterEngineTestCase.php

src/markup/syntax/highlighter/PhutilConsoleSyntaxHighlighter.php

src/markup/syntax/highlighter/PhutilDefaultSyntaxHighlighter.php

src/markup/syntax/highlighter/PhutilDivinerSyntaxHighlighter.php

src/markup/syntax/highlighter/PhutilInvisibleSyntaxHighlighter.php

src/markup/syntax/highlighter/PhutilLexerSyntaxHighlighter.php

src/markup/syntax/highlighter/PhutilPygmentsSyntaxHighlighter.php

src/markup/syntax/highlighter/PhutilRainbowSyntaxHighlighter.php

src/markup/syntax/highlighter/PhutilSyntaxHighlighter.php

src/markup/syntax/highlighter/PhutilSyntaxHighlighterException.php

src/markup/syntax/highlighter/PhutilXHPASTSyntaxHighlighter.php

src/markup/syntax/highlighter/__tests__/PhutilJSONFragmentLexerHighlighterTestCase.php

src/markup/syntax/highlighter/__tests__/PhutilPHPFragmentLexerHighlighterTestCase.php

src/markup/syntax/highlighter/__tests__/PhutilXHPASTSyntaxHighlighterTestCase.php

src/markup/syntax/highlighter/__tests__/data/jsonfragment/basics.expect

src/markup/syntax/highlighter/__tests__/data/jsonfragment/basics.test

src/markup/syntax/highlighter/__tests__/phpfragment/abuse.expect

src/markup/syntax/highlighter/__tests__/phpfragment/abuse.test

src/markup/syntax/highlighter/__tests__/phpfragment/basics.expect

src/markup/syntax/highlighter/__tests__/phpfragment/basics.test

src/markup/syntax/highlighter/__tests__/phpfragment/leading-whitespace.expect

src/markup/syntax/highlighter/__tests__/phpfragment/leading-whitespace.test

src/markup/syntax/highlighter/__tests__/phpfragment/no-leading-whitespace.expect

src/markup/syntax/highlighter/__tests__/phpfragment/no-leading-whitespace.test

src/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.expect

src/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.source

src/markup/syntax/highlighter/__tests__/xhpast/leading-whitespace.expect

src/markup/syntax/highlighter/__tests__/xhpast/leading-whitespace.source

src/markup/syntax/highlighter/__tests__/xhpast/multiline-token.expect

src/markup/syntax/highlighter/__tests__/xhpast/multiline-token.source

src/markup/syntax/highlighter/__tests__/xhpast/no-leading-whitespace.expect

src/markup/syntax/highlighter/__tests__/xhpast/no-leading-whitespace.source

src/markup/syntax/highlighter/__tests__/xhpast/trailing-comment.expect

src/markup/syntax/highlighter/__tests__/xhpast/trailing-comment.source

src/markup/syntax/highlighter/pygments/PhutilDefaultSyntaxHighlighterEnginePygmentsFuture.php

src/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php

src/parser/PhutilPygmentizeParser.php

src/parser/__tests__/PhutilPygmentizeParserTestCase.php

src/sprites/PhutilSprite.php

src/sprites/PhutilSpriteSheet.php

src/utils/utils.php

Move additional classes out of libphutil, to Phabricator
ClosedPublic
Actions

Revision Contents
Changeset List

src/cache/tests/PhutilKeyValueCacheTestCase.php

src/internationalization/tests/PhutilTranslatorTestCase.php

src/markup/tests/PhutilMarkupTestCase.php

src/markup/tests/PhutilSafeHTMLTestCase.php

src/markup/syntax/engine/tests/PhutilDefaultSyntaxHighlighterEngineTestCase.php

src/markup/syntax/highlighter/tests/PhutilJSONFragmentLexerHighlighterTestCase.php

src/markup/syntax/highlighter/tests/PhutilPHPFragmentLexerHighlighterTestCase.php

src/markup/syntax/highlighter/tests/PhutilXHPASTSyntaxHighlighterTestCase.php

src/markup/syntax/highlighter/tests/data/jsonfragment/basics.expect

src/markup/syntax/highlighter/tests/data/jsonfragment/basics.test

src/markup/syntax/highlighter/tests/phpfragment/abuse.expect

src/markup/syntax/highlighter/tests/phpfragment/abuse.test

src/markup/syntax/highlighter/tests/phpfragment/basics.expect

src/markup/syntax/highlighter/tests/phpfragment/basics.test

src/markup/syntax/highlighter/tests/phpfragment/leading-whitespace.expect

src/markup/syntax/highlighter/tests/phpfragment/leading-whitespace.test

src/markup/syntax/highlighter/tests/phpfragment/no-leading-whitespace.expect

src/markup/syntax/highlighter/tests/phpfragment/no-leading-whitespace.test

src/markup/syntax/highlighter/tests/xhpast/builtin-classname.expect

src/markup/syntax/highlighter/tests/xhpast/builtin-classname.source

src/markup/syntax/highlighter/tests/xhpast/leading-whitespace.expect

src/markup/syntax/highlighter/tests/xhpast/leading-whitespace.source

src/markup/syntax/highlighter/tests/xhpast/multiline-token.expect

src/markup/syntax/highlighter/tests/xhpast/multiline-token.source

src/markup/syntax/highlighter/tests/xhpast/no-leading-whitespace.expect

src/markup/syntax/highlighter/tests/xhpast/no-leading-whitespace.source

src/markup/syntax/highlighter/tests/xhpast/trailing-comment.expect

src/markup/syntax/highlighter/tests/xhpast/trailing-comment.source

src/parser/tests/PhutilPygmentizeParserTestCase.php