Page MenuHomePhabricator
Differential D20977

Continue moving classes with no callers in libphutil or Arcanist to Phabricator
ClosedPublic
Actions

Authored by epriestley on Feb 12 2020, 8:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 7:38 AM
Unknown Object (File)
Tue, Jan 28, 5:25 AM
Unknown Object (File)
Tue, Jan 28, 1:04 AM
Unknown Object (File)
Mon, Jan 27, 5:24 PM
Unknown Object (File)
Sat, Jan 25, 6:28 AM
Unknown Object (File)
Sat, Jan 25, 6:28 AM
Unknown Object (File)
Sat, Jan 25, 6:27 AM
Unknown Object (File)
Sat, Jan 25, 6:27 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13395: Strip libphutil for parts
Commits
rPf9b3e3360b0c: Continue moving classes with no callers in libphutil or Arcanist to Phabricator
Summary

Ref T13395. Move cache classes, syntax highlighters, other markup classes, and sprite sheets to Phabricator.

Test Plan

Attempted to find any callers for any of this stuff in libphutil or Arcanist and couldn't.

Diff Detail

Repository
rP Phabricator
Branch
strip3
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/infrastructure/cache/PhutilAPCKeyValueCache.php:29XHP45PHP Compatibility
Errorsrc/infrastructure/cache/PhutilAPCKeyValueCache.php:52XHP45PHP Compatibility
Errorsrc/infrastructure/cache/PhutilAPCKeyValueCache.php:69XHP45PHP Compatibility
Errorsrc/infrastructure/cache/PhutilAPCKeyValueCache.php:85XHP45PHP Compatibility
Warningsrc/infrastructure/markup/PhutilSafeHTML.php:30XHP95Self Class Reference
Warningsrc/infrastructure/markup/PhutilSafeHTML.php:40XHP9Naming Conventions
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/abuse.expect:9TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/basics.expect:1TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/basics.expect:2TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/basics.expect:3TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/basics.expect:4TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/leading-whitespace.expect:1TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/no-leading-whitespace.expect:1TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.expect:3TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.expect:4TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.expect:5TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.expect:6TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.expect:7TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.expect:8TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/xhpast/leading-whitespace.expect:1TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/xhpast/leading-whitespace.expect:2TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/xhpast/no-leading-whitespace.expect:1TXT3Line Too Long
Warningsrc/infrastructure/markup/syntax/highlighter/__tests__/xhpast/no-leading-whitespace.expect:2TXT3Line Too Long
Advicesrc/infrastructure/cache/PhutilKeyValueCacheStack.php:92XHP16TODO Comment
Advicesrc/infrastructure/markup/syntax/highlighter/PhutilPygmentsSyntaxHighlighter.php:16XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 23806
Build 32740: Run Core Tests
Build 32739: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 49981.Feb 12 2020, 8:01 PM
epriestley created this revision.
  • Bring over the "*.expect" rule in ".arclint".
Harbormaster completed remote builds in B23806: Diff 49980.Feb 12 2020, 8:03 PM
Harbormaster completed remote builds in B23807: Diff 49981.
epriestley requested review of this revision.Feb 12 2020, 8:04 PM
epriestley updated this revision to Diff 49983.Feb 12 2020, 8:08 PM
  • Also move the "Pygmentize" parser.
Harbormaster completed remote builds in B23809: Diff 49983.Feb 12 2020, 8:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2020, 9:14 PM
This revision was landed with ongoing or failed builds.
Closed by commit rPf9b3e3360b0c: Continue moving classes with no callers in libphutil or Arcanist to Phabricator (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPf9b3e3360b0c: Continue moving classes with no callers in libphutil or Arcanist to Phabricator.

Revision Contents
Changeset List

PathSize
src/
aphront/
sprite/
76 lines
385 lines
infrastructure/
cache/
97 lines
244 lines
118 lines
121 lines
65 lines
108 lines
45 lines
131 lines
153 lines
205 lines
__tests__/
267 lines
lipsum/
93 lines
markup/
32 lines
44 lines
12 lines
__tests__/
223 lines
19 lines
251 lines
syntax/
engine/
115 lines
19 lines
__tests__/
28 lines
highlighter/
51 lines
14 lines
81 lines
43 lines
72 lines
229 lines
46 lines
6 lines
3 lines
18 lines
__tests__/
24 lines
25 lines
39 lines
data/
jsonfragment/
12 lines
12 lines
phpfragment/
16 lines
16 lines
5 lines
5 lines
3 lines
3 lines
3 lines
3 lines
xhpast/
10 lines
10 lines
3 lines
3 lines
5 lines
5 lines
3 lines
3 lines
3 lines
2 lines
pygments/
33 lines
xhpast/
262 lines

Diff 49980

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/aphront/sprite/PhutilSprite.php

Loading...
View Options

src/aphront/sprite/PhutilSpriteSheet.php

Loading...
View Options

src/infrastructure/cache/PhutilAPCKeyValueCache.php

Loading...
View Options

src/infrastructure/cache/PhutilDirectoryKeyValueCache.php

Loading...
View Options

src/infrastructure/cache/PhutilInRequestKeyValueCache.php

Loading...
View Options

src/infrastructure/cache/PhutilKeyValueCache.php

Loading...
View Options

src/infrastructure/cache/PhutilKeyValueCacheNamespace.php

Loading...
View Options

src/infrastructure/cache/PhutilKeyValueCacheProfiler.php

Loading...
View Options

src/infrastructure/cache/PhutilKeyValueCacheProxy.php

Loading...
View Options

src/infrastructure/cache/PhutilKeyValueCacheStack.php

Loading...
View Options

src/infrastructure/cache/PhutilMemcacheKeyValueCache.php

Loading...
View Options

src/infrastructure/cache/PhutilOnDiskKeyValueCache.php

Loading...
View Options

src/infrastructure/cache/__tests__/PhutilKeyValueCacheTestCase.php

Loading...
View Options

src/infrastructure/lipsum/PhutilContextFreeGrammar.php

Loading...
View Options

src/infrastructure/markup/PhutilMarkupEngine.php

Loading...
View Options

src/infrastructure/markup/PhutilSafeHTML.php

Loading...
View Options

src/infrastructure/markup/PhutilSafeHTMLProducerInterface.php

Loading...
View Options

src/infrastructure/markup/__tests__/PhutilMarkupTestCase.php

Loading...
View Options

src/infrastructure/markup/__tests__/PhutilSafeHTMLTestCase.php

Loading...
View Options

src/infrastructure/markup/render.php

Loading...
View Options

src/infrastructure/markup/syntax/engine/PhutilDefaultSyntaxHighlighterEngine.php

Loading...
View Options

src/infrastructure/markup/syntax/engine/PhutilSyntaxHighlighterEngine.php

Loading...
View Options

src/infrastructure/markup/syntax/engine/__tests__/PhutilDefaultSyntaxHighlighterEngineTestCase.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/PhutilConsoleSyntaxHighlighter.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/PhutilDefaultSyntaxHighlighter.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/PhutilDivinerSyntaxHighlighter.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/PhutilInvisibleSyntaxHighlighter.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/PhutilLexerSyntaxHighlighter.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/PhutilPygmentsSyntaxHighlighter.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/PhutilRainbowSyntaxHighlighter.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/PhutilSyntaxHighlighter.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/PhutilSyntaxHighlighterException.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/PhutilXHPASTSyntaxHighlighter.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/PhutilJSONFragmentLexerHighlighterTestCase.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/PhutilPHPFragmentLexerHighlighterTestCase.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/PhutilXHPASTSyntaxHighlighterTestCase.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/data/jsonfragment/basics.expect

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/data/jsonfragment/basics.test

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/abuse.expect

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/abuse.test

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/basics.expect

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/basics.test

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/leading-whitespace.expect

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/leading-whitespace.test

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/no-leading-whitespace.expect

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/no-leading-whitespace.test

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.expect

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.source

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/leading-whitespace.expect

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/leading-whitespace.source

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/multiline-token.expect

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/multiline-token.source

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/no-leading-whitespace.expect

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/no-leading-whitespace.source

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/trailing-comment.expect

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/trailing-comment.source

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/pygments/PhutilDefaultSyntaxHighlighterEnginePygmentsFuture.php

Loading...
View Options

src/infrastructure/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php

Loading...
Phabricator · Built by Phacility