Page MenuHomePhabricator

Remove legacy pre-loading of handles from Herald rendering
ClosedPublic

Authored by epriestley on Jan 23 2020, 7:42 PM.
Tags
None
Referenced Files
F14091510: D20948.id49926.diff
Mon, Nov 25, 12:28 AM
Unknown Object (File)
Wed, Nov 20, 4:36 AM
Unknown Object (File)
Sat, Nov 16, 12:34 PM
Unknown Object (File)
Fri, Nov 15, 5:50 PM
Unknown Object (File)
Wed, Nov 13, 7:31 AM
Unknown Object (File)
Tue, Nov 12, 7:31 AM
Unknown Object (File)
Fri, Nov 8, 9:51 PM
Unknown Object (File)
Fri, Nov 8, 5:56 AM
Subscribers
None

Details

Summary

Ref T13480. When Herald renders rules, it partly uses a very old handle pre-loading mechanism where PHIDs are extracted and loaded upfront. This was obsoleted a long time ago and was pretty shaky even when it worked. Get rid of it to simplify the code a little.

Test Plan

Viewed Herald rules rendered into static text with PHID list actions, saw handles. Grepped for all affected methods.

Diff Detail

Repository
rP Phabricator
Branch
author3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23737
Build 32641: Run Core Tests
Build 32640: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2020, 11:07 PM
This revision was automatically updated to reflect the committed changes.