Differential D20947

Implement an "Author's packages" Herald field for Differential
ClosedPublic
Actions

Authored by epriestley on Jan 23 2020, 2:17 AM.

Details

Reviewers: None
Maniphest Tasks: T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields
Commits: rPb38449ce8f4b: Implement an "Author's packages" Herald field for Differential

Summary

Ref T13480. Add an "Author's packages" field to Herald to support writing rules like "if affected packages include X, and author's packages do not include X, raise the alarm".

Test Plan

Wrote and executed rules with the field, saw a sensible field value in the transcript.

Diff Detail

Repository

rP Phabricator

Branch

herald2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23734
Build 32637: Run Core Tests
Build 32636: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 23 2020, 2:17 AM

Harbormaster completed remote builds in B23734: Diff 49908.Jan 23 2020, 2:19 AM

epriestley requested review of this revision.Jan 23 2020, 2:19 AM

epriestley mentioned this in T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.Jan 23 2020, 2:20 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2020, 2:27 AM

Closed by commit rPb38449ce8f4b: Implement an "Author's packages" Herald field for Differential (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb38449ce8f4b: Implement an "Author's packages" Herald field for Differential.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

differential/

herald/

DifferentialRevisionAuthorPackagesHeraldField.php

32 lines

Diff 49908

View Options

src/__phutil_library_map__.php