Differential D20924

Remove "phlog()" of exeptions during Conduit calls
ClosedPublic
Actions

Authored by epriestley on Nov 22 2019, 7:54 PM.

Tags

None

Referenced Files

	F19940181: D20924.diff
	Tue, Apr 14, 10:29 PM

	F19554095: D20924.id49866.diff
	Jan 29 2026, 5:26 PM

	F19510866: D20924.diff
	Jan 11 2026, 4:23 PM

	F19083137: D20924.id49866.diff
	Dec 2 2025, 12:31 PM

	F18985293: D20924.id49865.diff
	Nov 17 2025, 12:58 PM

	F18810282: D20924.diff
	Oct 19 2025, 8:50 PM

	F18805062: D20924.id49866.diff
	Oct 18 2025, 1:33 PM

	F18805061: D20924.id49865.diff
	Oct 18 2025, 1:33 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13465: Stop sending Conduit exceptions to the error log
Commits: rPeb6df7a2091a: Remove "phlog()" of exeptions during Conduit calls

Summary

Fixes T13465. This "phlog()" made some degree of sense at one time, but is no longer useful or consistent. Get rid of it. See T13465 for discussion.

Test Plan

Made a conduit call that hit a policy error, no longer saw error in log.

Diff Detail

Repository

rP Phabricator

Branch

conduit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23694
Build 32576: Run Core Tests
Build 32575: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 22 2019, 7:54 PM

Harbormaster completed remote builds in B23694: Diff 49865.Nov 22 2019, 7:56 PM

epriestley requested review of this revision.Nov 22 2019, 7:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 22 2019, 8:03 PM

Closed by commit rPeb6df7a2091a: Remove "phlog()" of exeptions during Conduit calls (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPeb6df7a2091a: Remove "phlog()" of exeptions during Conduit calls.

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

controller/

PhabricatorConduitAPIController.php

3 lines

Diff 49865

View Options

src/applications/conduit/controller/PhabricatorConduitAPIController.php

Remove "phlog()" of exeptions during Conduit callsClosedPublicActions