Page MenuHomePhabricator
Differential D20924

Remove "phlog()" of exeptions during Conduit calls
ClosedPublic
Actions

Authored by epriestley on Nov 22 2019, 7:54 PM.
Tags
None
Referenced Files
F15483498: D20924.id49866.diff
Wed, Apr 9, 12:40 PM
F15473150: D20924.diff
Sat, Apr 5, 7:48 PM
F15467606: D20924.id49865.diff
Thu, Apr 3, 4:42 PM
F15465758: D20924.id49866.diff
Wed, Apr 2, 10:54 PM
F15465163: D20924.id.diff
Wed, Apr 2, 3:20 PM
F15463276: D20924.diff
Tue, Apr 1, 9:56 PM
F15447434: D20924.diff
Thu, Mar 27, 11:52 PM
F15424286: D20924.id.diff
Sat, Mar 22, 9:16 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13465: Stop sending Conduit exceptions to the error log
Commits
rPeb6df7a2091a: Remove "phlog()" of exeptions during Conduit calls
Summary

Fixes T13465. This "phlog()" made some degree of sense at one time, but is no longer useful or consistent. Get rid of it. See T13465 for discussion.

Test Plan

Made a conduit call that hit a policy error, no longer saw error in log.

Diff Detail

Repository
rP Phabricator
Branch
conduit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23694
Build 32576: Run Core Tests
Build 32575: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 22 2019, 7:54 PM
Harbormaster completed remote builds in B23694: Diff 49865.Nov 22 2019, 7:56 PM
epriestley requested review of this revision.Nov 22 2019, 7:56 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 22 2019, 8:03 PM
Closed by commit rPeb6df7a2091a: Remove "phlog()" of exeptions during Conduit calls (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPeb6df7a2091a: Remove "phlog()" of exeptions during Conduit calls.

Revision Contents
Changeset List

PathSize
src/
applications/
conduit/
controller/
3 lines

Diff 49865

View Options

src/applications/conduit/controller/PhabricatorConduitAPIController.php

Loading...
Phabricator · Built by Phacility