Page MenuHomePhabricator
Differential D20913

Give "PhabricatorUserEmail" a PHID
ClosedPublic
Actions

Authored by epriestley on Nov 14 2019, 7:31 PM.
Tags
None
Referenced Files
F22674754: D20913.id.diff
Thu, Oct 1, 9:10 PM
F22674749: D20913.id.diff
Thu, Oct 1, 9:10 PM
Unknown Object (File)
Sun, Sep 6, 11:27 AM
Unknown Object (File)
Sat, Sep 5, 4:24 AM
Unknown Object (File)
Aug 23 2026, 4:37 PM
Unknown Object (File)
Jul 1 2026, 4:30 AM
Unknown Object (File)
Jun 28 2026, 2:37 AM
Unknown Object (File)
Jun 22 2026, 4:05 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13444: Provide a standalone script entry point for resolving a repository identity
Commits
rP89dcf9792a0a: Give "PhabricatorUserEmail" a PHID
Summary

Ref T13444. To interact meaningfully with "DestructionEngine", objects need a PHID. The "UserEmail" object currently does not have one (or a real "Query").

Provide basic PHID support so "DestructionEngine" can interact with the object more powerfully.

Test Plan
  • Ran migrations, checked data in database, saw sensible PHIDs assigned.
  • Added a new email address to my account, saw it get a PHID.

Diff Detail

Repository
rP Phabricator
Branch
identity7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23663
Build 32534: Run Core Tests
Build 32533: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 14 2019, 7:31 PM
Owners added a subscriber: Restricted Owners Package.Nov 14 2019, 7:31 PM
Harbormaster completed remote builds in B23663: Diff 49835.Nov 14 2019, 7:32 PM
epriestley requested review of this revision.Nov 14 2019, 7:32 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2019, 5:41 PM
Closed by commit rP89dcf9792a0a: Give "PhabricatorUserEmail" a PHID (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP89dcf9792a0a: Give "PhabricatorUserEmail" a PHID.

Revision Contents
Changeset List

Diff 49835

View Options

resources/sql/autopatches/20191114.email.01.phid.sql

Loading...
View Options

resources/sql/autopatches/20191114.email.02.populate.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/people/phid/PhabricatorPeopleUserEmailPHIDType.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleUserEmailQuery.php

Loading...
View Options

src/applications/people/storage/PhabricatorUserEmail.php

Loading...
Phabricator · Built by Phacility