Page MenuHomePhabricator

Consolidate repository identity resolution and detection code
ClosedPublic

Authored by epriestley on Nov 14 2019, 4:50 AM.
Tags
None
Referenced Files
F13958726: D20910.id49832.diff
Mon, Oct 14, 4:16 PM
Unknown Object (File)
Sun, Oct 13, 9:16 PM
Unknown Object (File)
Sep 26 2024, 3:57 PM
Unknown Object (File)
Sep 26 2024, 11:38 AM
Unknown Object (File)
Sep 3 2024, 11:42 PM
Unknown Object (File)
Sep 3 2024, 5:47 PM
Unknown Object (File)
Sep 2 2024, 9:57 PM
Unknown Object (File)
Aug 31 2024, 9:03 PM
Subscribers
None

Details

Summary

Ref T13444. Send all repository identity/detection through a new "DiffusionRepositoryIdentityEngine" which handles resolution and detection updates in one place.

Test Plan
  • Ran bin/repository reparse --message ..., saw author/committer identity updates.
  • Added "goose@example.com" to my email addresses, ran daemons, saw the identity relationship get picked up.
  • Ran bin/repository rebuild-identities ..., saw sensible rebuilds.

Diff Detail

Repository
rP Phabricator
Branch
identity4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23660
Build 32528: Run Core Tests
Build 32527: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2019, 5:39 PM
This revision was automatically updated to reflect the committed changes.