Differential D20902

Improve recovery from panel action rendering exceptions, and mark "Changeset" queries as not suitable for panel generation
ClosedPublic
Actions

Authored by epriestley on Nov 9 2019, 1:12 AM.

Tags

None

Referenced Files

	F15470347: D20902.id49820.diff
	Fri, Apr 4, 9:38 PM

	F15436802: D20902.id49821.diff
	Tue, Mar 25, 4:35 PM

	F15434216: D20902.id49820.diff
	Tue, Mar 25, 2:42 AM

	F15428304: D20902.id.diff
	Sun, Mar 23, 7:04 PM

	F15423216: D20902.diff
	Sat, Mar 22, 2:02 PM

	F15409997: D20902.diff
	Wed, Mar 19, 6:30 AM

	Unknown Object (File)
	Feb 26 2025, 8:39 AM

	Unknown Object (File)
	Feb 24 2025, 2:25 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13443: Creating a dashboard query panel with the type "Differential Changesets" breaks the dashboard editor
Commits: rP72f82abe0723: Improve recovery from panel action rendering exceptions, and mark "Changeset"…

Summary

Fixes T13443. When a panel raises an exception during edit action generation, it currently escapes to top level. Instead, catch it more narrowly.

Additionally, mark "ChangesetSearchEngine" as not being a suitable search engine for use in query panels. There's no list view or search URI so it can't generate a sensible panel.

Test Plan

Added a changeset panel to a dashboard.
Before: entire dashboard fataled.
After: panel fataled narrowly, menu fatals narrowly, dashboard no longer permits creation of another Changeset query panel.

Diff Detail

Repository

Branch

panel1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23648
Build 32509: Run Core Tests
Build 32508: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 9 2019, 1:12 AM

Harbormaster completed remote builds in B23648: Diff 49820.Nov 9 2019, 1:13 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 9 2019, 1:13 AM

epriestley requested review of this revision.

Closed by commit rP72f82abe0723: Improve recovery from panel action rendering exceptions, and mark "Changeset"… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP72f82abe0723: Improve recovery from panel action rendering exceptions, and mark "Changeset"….

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

engine/

PhabricatorDashboardPanelRenderingEngine.php

13 lines

differential/

query/

DifferentialChangesetSearchEngine.php

4 lines

Diff 49820

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...

src/applications/differential/query/DifferentialChangesetSearchEngine.php

Loading...