Differential D20895

When "Fetch Refs" are configured for a repository, highlight the "Branches" menu item in the Diffusion Management UI
ClosedPublic
Actions

Authored by epriestley on Nov 8 2019, 12:25 AM.

Tags

None

Referenced Files

	F19828517: D20895.diff
	Mon, Mar 9, 7:15 PM

	F19826990: D20895.diff
	Mon, Mar 9, 4:34 AM

	F19811283: D20895.id49806.diff
	Tue, Mar 3, 11:34 PM

	F19259299: D20895.id49806.diff
	Dec 22 2025, 3:21 PM

	F18985271: D20895.id.diff
	Nov 17 2025, 12:57 PM

	F18854745: D20895.diff
	Nov 1 2025, 12:32 AM

	F18850043: D20895.id49806.diff
	Oct 30 2025, 2:02 PM

	F18834774: D20895.id49805.diff
	Oct 26 2025, 10:45 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13448: Respect "Fetch Refs" when cloning a new repository
Commits: rP502ca4767e4b: When "Fetch Refs" are configured for a repository, highlight the "Branches"…

Summary

Ref T13448. Minor UI issue: setting a "Fetch Refs" value does not highlight the associated menu item, but should.

Test Plan

Set only "Fetch Refs", now saw menu item highlighted.

Diff Detail

Repository

rP Phabricator

Branch

ref4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23634
Build 32489: Run Core Tests
Build 32488: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 8 2019, 12:25 AM

Harbormaster completed remote builds in B23634: Diff 49805.Nov 8 2019, 12:27 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 8 2019, 12:27 AM

epriestley requested review of this revision.

Closed by commit rP502ca4767e4b: When "Fetch Refs" are configured for a repository, highlight the "Branches"… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP502ca4767e4b: When "Fetch Refs" are configured for a repository, highlight the "Branches"….

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

management/

DiffusionRepositoryBranchesManagementPanel.php

1 line

Diff 49805

View Options

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

When "Fetch Refs" are configured for a repository, highlight the "Branches" menu item in the Diffusion Management UIClosedPublicActions