Page MenuHomePhabricator

Change the Herald "do not include [any of]" condition label to "include none of"
ClosedPublic

Authored by epriestley on Nov 6 2019, 3:53 PM.
Tags
None
Referenced Files
F15419525: D20889.id49795.diff
Fri, Mar 21, 6:45 AM
F15411294: D20889.diff
Wed, Mar 19, 8:58 AM
F15411241: D20889.diff
Wed, Mar 19, 8:56 AM
F15411175: D20889.diff
Wed, Mar 19, 8:53 AM
F15411038: D20889.diff
Wed, Mar 19, 8:48 AM
F15410275: D20889.diff
Wed, Mar 19, 6:59 AM
F15405214: D20889.id.diff
Tue, Mar 18, 10:41 AM
F15401695: D20889.diff
Mon, Mar 17, 6:53 PM
Subscribers
None

Details

Summary

Fixes T13445. Make the meaning of this condition more clear, since the current wording is ambiguous between "any of" and "all of".

Test Plan

Edited a Herald rule with a PHID list field ("Project tags"), saw text label say "include none of".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 6 2019, 3:55 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.