Change the Herald "do not include [any of]" condition label to "include none of"
ClosedPublic
Actions

Authored by epriestley on Nov 6 2019, 3:53 PM.

Details

Reviewers: None
Maniphest Tasks: T13445: Improve clarity of "do not include" condition in Herald
Commits: rP6bada7db4ceb: Change the Herald "do not include [any of]" condition label to "include none of"

Summary

Fixes T13445. Make the meaning of this condition more clear, since the current wording is ambiguous between "any of" and "all of".

Test Plan

Edited a Herald rule with a PHID list field ("Project tags"), saw text label say "include none of".

Repository

rP Phabricator

Branch

none1

Lint

Lint Passed

Unit

Tests Passed

Build Status

This revision was not accepted when it landed; it landed in state Needs Review.Nov 6 2019, 3:55 PM

epriestley requested review of this revision.

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

herald/

adapter/

2 lines