Page MenuHomePhabricator

Make "arc land --merge" an explicit error when targeting a Perforce remote
ClosedPublic

Authored by epriestley on Oct 28 2019, 6:52 PM.
Tags
None
Referenced Files
F15412649: D20871.diff
Wed, Mar 19, 2:10 PM
F15410305: D20871.id49755.diff
Wed, Mar 19, 7:03 AM
F15357336: D20871.diff
Tue, Mar 11, 6:40 AM
Unknown Object (File)
Feb 16 2025, 11:26 AM
Unknown Object (File)
Feb 9 2025, 8:19 AM
Unknown Object (File)
Feb 9 2025, 8:19 AM
Unknown Object (File)
Feb 9 2025, 8:19 AM
Unknown Object (File)
Feb 9 2025, 8:19 AM
Subscribers
None

Details

Summary

Ref T13434. Since "git p4 submit" gets more complicated when submitting merges, and empty merges (as with "--no-ff") seem to vanish, and it's not clear this is desirable or useful anyway, just make the "merge" strategy an explicit error with Perforce remotes.

Test Plan

Ran "arc land --merge ..." in a Git/Perforce repository, got an explicit error. Ran "arc land --squash ...", got existing working behavior.

Diff Detail

Repository
rARC Arcanist
Branch
perforce5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23584
Build 32415: Run Core Tests
Build 32414: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 28 2019, 6:59 PM
This revision was automatically updated to reflect the committed changes.