Differential D20827

When non-administrators click "Change Username", explain why they can't continue
ClosedPublic
Actions

Authored by epriestley on Sep 24 2019, 5:41 PM.

Tags

None

Referenced Files

	F13247911: D20827.id49651.diff
	Thu, May 23, 11:25 PM

	F13247378: D20827.id.diff
	Thu, May 23, 6:51 PM

	F13244026: D20827.diff
	Thu, May 23, 4:26 AM

	F13226794: D20827.id49651.diff
	Sun, May 19, 11:28 PM

	F13222505: D20827.diff
	Sun, May 19, 3:43 AM

	F13205157: D20827.diff
	Wed, May 15, 1:29 AM

	F13188504: D20827.diff
	Sat, May 11, 5:17 AM

	Unknown Object (File)
	Tue, May 7, 8:32 AM

View All 84 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13420: Update "Change Username" to make it more friendly for non-administrators
Commits: rP0c331458a88b: When non-administrators click "Change Username", explain why they can't continue

Summary

Ref T13420. This workflow currently dead-ends for non-administrators. Instead, provide explanatory text.

Test Plan

Clicked "Change Username" as an administrator, same workflow as always.
Clicked "Change Username" as a non-administrator, got explanatory text.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 24 2019, 5:41 PM

Harbormaster completed remote builds in B23478: Diff 49651.Sep 24 2019, 5:43 PM

epriestley requested review of this revision.Sep 24 2019, 5:43 PM

epriestley edited the test plan for this revision. (Show Details)Sep 24 2019, 5:49 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 6:08 PM

Closed by commit rP0c331458a88b: When non-administrators click "Change Username", explain why they can't continue (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0c331458a88b: When non-administrators click "Change Username", explain why they can't continue.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleRenameController.php

15 lines

Diff 49657

src/applications/people/controller/PhabricatorPeopleRenameController.php

Loading...