Differential D20826

Update "Change Username" instructions to be less foreboding
ClosedPublic
Actions

Authored by epriestley on Sep 24 2019, 5:36 PM.

Details

Reviewers: None
Maniphest Tasks: T13420: Update "Change Username" to make it more friendly for non-administrators
Commits: rP058b7ae9450d: Update "Change Username" instructions to be less foreboding

Summary

Ref T13420. These warnings are currently more severe than they need to be; weaken them.

Among other cases, the upstream supports and encourages changing usernames when users change human names.

The login/password instructions are also out of date since sessions were decoupled from usernames about a year ago.

Test Plan

Hit dialog as an administrator

Diff Detail

Repository

rP Phabricator

Branch

user1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23477
Build 32262: Run Core Tests
Build 32261: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 24 2019, 5:36 PM

Harbormaster completed remote builds in B23477: Diff 49650.Sep 24 2019, 5:38 PM

epriestley requested review of this revision.Sep 24 2019, 5:38 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 6:08 PM

Closed by commit rP058b7ae9450d: Update "Change Username" instructions to be less foreboding (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP058b7ae9450d: Update "Change Username" instructions to be less foreboding.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleRenameController.php

58 lines

Diff 49650

View Options

src/applications/people/controller/PhabricatorPeopleRenameController.php

Update "Change Username" instructions to be less forebodingClosedPublicActions