Differential D20824

", not just immediate children
ClosedPublic
Actions

Authored by epriestley on Sep 24 2019, 4:40 PM.

Tags

None

Referenced Files

	F19083071: D20824.id49648.diff
	Dec 2 2025, 12:30 PM

	F18985218: D20824.id49647.diff
	Nov 17 2025, 12:56 PM

	F18761370: D20824.diff
	Oct 6 2025, 1:56 PM

	F18754795: D20824.id49648.diff
	Oct 5 2025, 1:23 AM

	F18734049: D20824.id.diff
	Sep 30 2025, 10:47 PM

	F18673792: D20824.id49647.diff
	Sep 25 2025, 12:04 PM

	F18399358: D20824.diff
	Aug 29 2025, 4:09 PM

	F18102693: D20824.diff
	Aug 9 2025, 10:47 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13418: "arc liberate" incorrectly includes subdirectories of "src/extensions/" in library map
Commits: rPHU3b15fd0a01d4: Ignore all files in "src/extensions/", not just immediate children

Summary

Fixes T13418. This test ignores files in any directory named "extensions/", but the intent is to ignore all descendants of "src/extensions/".

Test Plan

Put files in "src/extensions/xyz/QQQ.php", ran "arc liberate", got a clean library map without the class in "QQQ.php" indexed.

Diff Detail

Repository

rPHU libphutil

Branch

ext1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23474
Build 32257: Run Core Tests
Build 32256: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 24 2019, 4:40 PM

Harbormaster completed remote builds in B23474: Diff 49647.Sep 24 2019, 4:41 PM

epriestley requested review of this revision.Sep 24 2019, 4:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 5:02 PM

Closed by commit rPHU3b15fd0a01d4: Ignore all files in "src/extensions/", not just immediate children (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPHU3b15fd0a01d4: Ignore all files in "src/extensions/", not just immediate children.

Revision Contents
Changeset List

Path

Size

src/

moduleutils/

PhutilLibraryMapBuilder.php

7 lines

Diff 49647

View Options

src/moduleutils/PhutilLibraryMapBuilder.php

Ignore all files in "src/extensions/", not just immediate childrenClosedPublicActions