Page MenuHomePhabricator

Remove "Editable By" description fields in Passphrase, Phame, and Spaces
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 7:35 AM
Unknown Object (File)
Thu, May 2, 4:37 AM
Unknown Object (File)
Thu, Apr 25, 1:37 AM
Unknown Object (File)
Thu, Apr 11, 9:21 AM
Unknown Object (File)
Fri, Apr 5, 6:53 AM
Unknown Object (File)
Mar 29 2024, 9:11 PM
Unknown Object (File)
Mar 29 2024, 1:50 PM
Unknown Object (File)
Mar 10 2024, 10:01 PM
Subscribers
None

Details

Summary

Ref T13411. These three applications render an "Editable By: <policy>" field in their descriptions.

The pages that these appear on all have "Edit <thing>" actions which either tell you the policy or allow you to discover the policy, and this field is unusual (the vast majority of objects don't have it). I think it largely got copy/pasted or used as space-filler and doesn't offer much of value.

Remove it to simplify/standardize these pages and make changes to how this field works simpler to implement.

Test Plan

Viewed a Credential, Blog, and Space; no longer saw the "Editable By" field.

Diff Detail

Repository
rP Phabricator
Branch
policy2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23423
Build 32180: Run Core Tests
Build 32179: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:37 PM
This revision was automatically updated to reflect the committed changes.