Page MenuHomePhabricator
Differential D20789

When users try to log out with no providers configured, warn them of the consequences
ClosedPublic
Actions

Authored by epriestley on Sep 8 2019, 4:48 PM.
Tags
None
Referenced Files
F15410681: D20789.id49568.diff
Wed, Mar 19, 8:10 AM
F15402452: D20789.id49568.diff
Mon, Mar 17, 10:36 PM
F15397746: D20789.id49569.diff
Sun, Mar 16, 10:04 PM
F15378852: D20789.id49568.diff
Thu, Mar 13, 5:21 PM
F15377252: D20789.id49568.diff
Thu, Mar 13, 8:28 AM
Unknown Object (File)
Feb 9 2025, 8:05 AM
Unknown Object (File)
Feb 9 2025, 8:05 AM
Unknown Object (File)
Feb 9 2025, 8:05 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13406: When a user with no authentication providers configured tries to log out, warn them
Commits
rPcaccbb69d20b: When users try to log out with no providers configured, warn them of the…
Summary

Fixes T13406. On the logout screen, test for no configured providers and warn users they may be getting into more trouble than they expect.

Test Plan
  • Logged out of a normal install and a fresh (unconfigured) install.

Screen Shot 2019-09-08 at 9.44.10 AM.png (954×1 px, 195 KB)

Diff Detail

Repository
rP Phabricator
Branch
logout1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23394
Build 32138: Run Core Tests
Build 32137: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 8 2019, 4:48 PM
Harbormaster completed remote builds in B23394: Diff 49568.Sep 8 2019, 4:50 PM
epriestley requested review of this revision.Sep 8 2019, 4:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 8 2019, 7:27 PM
Closed by commit rPcaccbb69d20b: When users try to log out with no providers configured, warn them of the… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPcaccbb69d20b: When users try to log out with no providers configured, warn them of the….

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
controller/
36 lines
config/
2 lines
view/
14 lines

Diff 49568

View Options

src/applications/auth/controller/PhabricatorLogoutController.php

Loading...
View Options

src/applications/auth/controller/config/PhabricatorAuthListController.php

Loading...
View Options

src/view/AphrontDialogView.php

Loading...
Phabricator · Built by Phacility