Page MenuHomePhabricator

When "utf8mb4" is available, use it as the default client charset when invoking standalone "mysql" commands
ClosedPublic

Authored by epriestley on Aug 27 2019, 10:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 12:28 AM
Unknown Object (File)
Fri, Apr 26, 8:49 PM
Unknown Object (File)
Fri, Apr 26, 12:52 PM
Unknown Object (File)
Thu, Apr 25, 4:45 PM
Unknown Object (File)
Wed, Apr 17, 3:06 PM
Unknown Object (File)
Tue, Apr 9, 11:08 AM
Unknown Object (File)
Mar 29 2024, 11:41 AM
Unknown Object (File)
Mar 10 2024, 3:31 PM
Subscribers
None

Details

Summary

Fixes T13390. We have some old code which doesn't dynamically select between "utf8mb4" and "utf8". This can lead to dumping utf8mb4 data over a utf8 connection in bin/storage dump, which possibly corrupts some emoji/whales.

Instead, prefer "utf8mb4" if it's available.

Test Plan

Ran bin/storage dump and bin/storage shell, saw sub-commands select utf8mb4 as the client charset.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable