Differential D20741

Fix incorrect construction of subtype map when validating "subtype" transactions against non-subtypable objects
ClosedPublic
Actions

Authored by epriestley on Aug 27 2019, 2:57 PM.

Tags

None

Referenced Files

	F13090646: D20741.id49457.diff
	Thu, Apr 25, 2:29 AM

	F13086707: D20741.diff
	Thu, Apr 25, 12:41 AM

	Unknown Object (File)
	Wed, Apr 24, 12:57 PM

	Unknown Object (File)
	Sat, Apr 20, 2:15 AM

	Unknown Object (File)
	Fri, Apr 19, 6:51 PM

	Unknown Object (File)
	Thu, Apr 11, 8:33 AM

	Unknown Object (File)
	Tue, Apr 2, 6:10 PM

	Unknown Object (File)
	Wed, Mar 27, 4:20 AM

View All 53 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13389: Editing Calendar forms can fail to build "newEditEngineSubtypeMap()" during transaction validation
Commits: rP0943561dcb78: Fix incorrect construction of subtype map when validating "subtype"…

Summary

Fixes T13389. Currently, we try to "newSubtypeMap()" unconditionally, even if the underlying object does not support subtypes.

Only try to build a subtype map if subtype transactions are actually being applied.
When subtype transactions are applied to a non-subtypable object, fail more explicitly.

Test Plan

Clicked "Make Editable" in a fresh Calendar transaction form, got an editable form instead of a fatal from "newSubtypeMap()". (Calendar events are not currently subtypable.)

Diff Detail

Repository

Branch

subtype1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23312
Build 32030: Run Core Tests
Build 32029: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 27 2019, 2:57 PM

Harbormaster completed remote builds in B23312: Diff 49454.Aug 27 2019, 2:58 PM

epriestley requested review of this revision.Aug 27 2019, 2:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2019, 1:57 PM

Closed by commit rP0943561dcb78: Fix incorrect construction of subtype map when validating "subtype"… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0943561dcb78: Fix incorrect construction of subtype map when validating "subtype"….

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

xaction/

PhabricatorEditEngineSubtypeTransaction.php

23 lines

Diff 49454

src/applications/transactions/xaction/PhabricatorEditEngineSubtypeTransaction.php

Loading...