Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision.search"
ClosedPublic
Actions

Authored by epriestley on Aug 22 2019, 8:21 PM.

Details

Reviewers: None
Maniphest Tasks: T13386: Offset paging in "differential.query" can overheat with a nonsensical error message
Commits: rP353155a2034e: Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision.

Summary

Fixes T13386. See PHI1391. These constraints largely exist already, but are not yet exposed to Conduit.

Also, tweak some keys to support the underlying query.

Test Plan

Ran differential.revision.search queries with the new constraints.

Diff Detail

Repository

rP Phabricator

Branch

mkey1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23282
Build 31990: Run Core Tests
Build 31989: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 22 2019, 8:21 PM

Harbormaster completed remote builds in B23282: Diff 49424.Aug 22 2019, 8:23 PM

epriestley requested review of this revision.Aug 22 2019, 8:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 22 2019, 8:34 PM

Closed by commit rP353155a2034e: Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision. (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP353155a2034e: Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision..

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionSearchEngine.php

18 lines

storage/

DifferentialRevision.php

8 lines

Diff 49424

View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php