Make the success message from "bin/config" more clear
ClosedPublic
Actions

Authored by epriestley on Aug 12 2019, 6:22 PM.

Details

Reviewers: None
Maniphest Tasks: T13373: Clarify some messaging in `bin/config`
Commits: rP006cb659cbf1: Make the success message from "bin/config" more clear

Summary

Ref T13373. When you "bin/config set x ..." a value, the success message ("Set x ...") is somewhat ambiguous and can be interpreted as "First, you need to set x..." rather than "Success, wrote x...".

Make the messaging more explicit. Also make this string more translatable.

Test Plan

Ran bin/config set ... with various combinations of flags, saw more clear messaging.

Diff Detail

Repository

rP Phabricator

Branch

config1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23248
Build 31935: Run Core Tests
Build 31934: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 12 2019, 6:22 PM

Harbormaster completed remote builds in B23248: Diff 49388.Aug 12 2019, 6:23 PM

epriestley requested review of this revision.Aug 12 2019, 6:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2019, 7:50 PM

Closed by commit rP006cb659cbf1: Make the success message from "bin/config" more clear (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP006cb659cbf1: Make the success message from "bin/config" more clear.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

management/

PhabricatorConfigManagementSetWorkflow.php

44 lines

infrastructure/

env/

PhabricatorConfigLocalSource.php

5 lines

Diff 49388

View Options

src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php