Differential D20710

Fix missing display cell in daemon summary table
ClosedPublic
Actions

Authored by epriestley on Aug 12 2019, 6:12 PM.

Tags

None

Referenced Files

	F19821592: D20710.id49390.diff
	Fri, Mar 6, 11:17 PM

	F19818780: D20710.id.diff
	Fri, Mar 6, 12:13 AM

	F19812901: D20710.id49387.diff
	Wed, Mar 4, 6:50 AM

	F19045952: D20710.id.diff
	Nov 27 2025, 9:18 AM

	F18831380: D20710.id49390.diff
	Oct 25 2025, 12:39 PM

	F18804463: D20710.id49387.diff
	Oct 18 2025, 8:34 AM

	F18756819: D20710.id.diff
	Oct 5 2025, 1:43 PM

	F18686090: D20710.diff
	Sep 26 2025, 12:03 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13374: Daemons summary table is missing a cell in the "Temporary Failures" row
Commits: rPc092492a53e0: Fix missing display cell in daemon summary table

Summary

Fixes T13374. The "Temporary Failures" row is missing a cell definiton from the addition of "Average Queue Time".

Test Plan

Viewed "/daemon/" with some temporary failures and and odd number of rows above the "Temporary Failures" row. Saw cell properly zebra-striped.

Diff Detail

Repository

rP Phabricator

Branch

row1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23247
Build 31933: Run Core Tests
Build 31932: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 12 2019, 6:12 PM

Harbormaster completed remote builds in B23247: Diff 49387.Aug 12 2019, 6:14 PM

epriestley requested review of this revision.Aug 12 2019, 6:14 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2019, 7:46 PM

Closed by commit rPc092492a53e0: Fix missing display cell in daemon summary table (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPc092492a53e0: Fix missing display cell in daemon summary table.

Revision Contents
Changeset List

Path

Size

src/

applications/

daemon/

controller/

PhabricatorDaemonConsoleController.php

1 line

Diff 49387

View Options

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

Fix missing display cell in daemon summary tableClosedPublicActions