Page MenuHomePhabricator
Differential D20710

Fix missing display cell in daemon summary table
ClosedPublic
Actions

Authored by epriestley on Aug 12 2019, 6:12 PM.
Tags
None
Referenced Files
F15487473: D20710.id49387.diff
Thu, Apr 10, 2:21 PM
F15485464: D20710.diff
Wed, Apr 9, 11:55 PM
F15481830: D20710.id49390.diff
Tue, Apr 8, 11:32 PM
F15470830: D20710.id49387.diff
Sat, Apr 5, 1:44 AM
F15470829: D20710.id.diff
Sat, Apr 5, 1:44 AM
F15470166: D20710.id49390.diff
Fri, Apr 4, 8:57 PM
F15469142: D20710.id.diff
Fri, Apr 4, 9:45 AM
F15468200: D20710.diff
Thu, Apr 3, 9:34 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13374: Daemons summary table is missing a cell in the "Temporary Failures" row
Commits
rPc092492a53e0: Fix missing display cell in daemon summary table
Summary

Fixes T13374. The "Temporary Failures" row is missing a cell definiton from the addition of "Average Queue Time".

Test Plan

Viewed "/daemon/" with some temporary failures and and odd number of rows above the "Temporary Failures" row. Saw cell properly zebra-striped.

Diff Detail

Repository
rP Phabricator
Branch
row1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23247
Build 31933: Run Core Tests
Build 31932: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 12 2019, 6:12 PM
Harbormaster completed remote builds in B23247: Diff 49387.Aug 12 2019, 6:14 PM
epriestley requested review of this revision.Aug 12 2019, 6:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2019, 7:46 PM
Closed by commit rPc092492a53e0: Fix missing display cell in daemon summary table (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPc092492a53e0: Fix missing display cell in daemon summary table.

Revision Contents
Changeset List

PathSize
src/
applications/
daemon/
controller/
1 line

Diff 49387

View Options

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

Loading...
Phabricator · Built by Phacility