Page MenuHomePhabricator

Address continue statement scope
AbandonedPublic

Authored by epriestley on Oct 21 2018, 9:08 PM.
Tags
None
Referenced Files
F13157083: D19749.id47181.diff
Sun, May 5, 9:00 AM
Unknown Object (File)
Fri, May 3, 12:21 PM
Unknown Object (File)
Fri, May 3, 2:25 AM
Unknown Object (File)
Mon, Apr 29, 1:55 PM
Unknown Object (File)
Wed, Apr 24, 10:01 PM
Unknown Object (File)
Sun, Apr 21, 4:07 PM
Unknown Object (File)
Fri, Apr 19, 8:02 PM
Unknown Object (File)
Thu, Apr 18, 11:43 PM
Subscribers

Details

Reviewers
dereckson
Group Reviewers
Blessed Reviewers
Summary

PHP 7.3 throws an exception when a continue is used inside a switch.

As the code intent is to skip the rest of the current outer loop iteration
(the loop containing the switch), there is a need to specify the level.

Test Plan

arc lint

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 21026
Build 28562: arc lint + arc unit

Unit TestsFailed

TimeTest
392 msArcanistPhpcsLinterTestCase::Unknown Unit Message ("")
In 'basics.lint-test', expected lint to raise error on line 2 at char 1, but no error was raised. Actually raised: No messages.
5,163 msArcanistRuboCopLinterTestCase::Unknown Unit Message ("")
In 'convention.lint-test', expected lint to raise warning on line 1 at char 10, but no warning was raised. Actually raised: No messages.
367 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
7 assertions passed.
25 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
3 assertions passed.
28 msArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
4 assertions passed.
View Full Test Results (2 Failed · 126 Passed · 27 Skipped)