Page MenuHomePhabricator
Differential D19307

Make repository symbol references work with DocumentEngine
ClosedPublic
Actions

Authored by epriestley on Apr 8 2018, 4:34 PM.
Tags
None
Referenced Files
F14418469: D19307.diff
Wed, Dec 25, 3:41 AM
Unknown Object (File)
Thu, Dec 12, 1:47 PM
Unknown Object (File)
Tue, Dec 10, 7:09 AM
Unknown Object (File)
Sun, Dec 8, 7:22 PM
Unknown Object (File)
Mon, Dec 2, 7:54 PM
Unknown Object (File)
Thu, Nov 28, 8:47 PM
Unknown Object (File)
Nov 23 2024, 9:38 PM
Unknown Object (File)
Nov 17 2024, 4:07 AM
View All Files
Subscribers
None

Details

Reviewers
mydeveloperday
Maniphest Tasks
T13047: Plans: Symbol Indexes
T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits
rP90a614778c07: Make repository symbol references work with DocumentEngine
Summary

Ref T13105. Ref T13047. This makes symbol indexes work with DocumentEngine in Files, and restores support in Diffusion.

Test Plan

Command-clicked stuff, got taken to the symbol index with reasonable metadata in Diffusion, Differential and Files.

Diff Detail

Repository
rP Phabricator
Branch
dfile6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20021
Build 27150: Run Core Tests
Build 27149: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
34 lines
src/
applications/
diffusion/
document/
20 lines
files/
document/
12 lines
2 lines
2 lines
7 lines
render/
7 lines
view/
layout/
21 lines
webroot/
rsrc/
css/
core/
13 lines
layout/
1 line
js/
application/
repository/
150 lines

Diff 46197

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/document/DiffusionDocumentRenderingEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorDocumentRef.php

Loading...
View Options

src/applications/files/document/PhabricatorJSONDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorSourceDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorTextDocumentEngine.php

Loading...
View Options

src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php

Loading...
View Options

src/view/layout/PhabricatorSourceCodeView.php

Loading...
View Options

webroot/rsrc/css/core/syntax.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-source-code-view.css

Loading...
View Options

webroot/rsrc/js/application/repository/repository-crossreference.js

Loading...
Phabricator · Built by Phacility