Differential D19306

Disable default syntax highlighting for large files in DocumentEngine
ClosedPublic
Actions

Authored by epriestley on Apr 8 2018, 3:13 PM.

Details

Reviewers

mydeveloperday

Maniphest Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types

Commits

rP0363febeb2c6: Disable default syntax highlighting for large files in DocumentEngine

Summary

Ref T13105. See also T7895. When users render very large files as source via DocumentEngine, skip highlighting.

Test Plan

Fiddled with the limit, viewed files, saw highlighting degrade.

Diff Detail

Repository

rP Phabricator

Branch

dfile5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20020
Build 27148: Run Core Tests
Build 27147: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 8 2018, 3:13 PM

Harbormaster completed remote builds in B20020: Diff 46196.Apr 8 2018, 3:14 PM

epriestley requested review of this revision.Apr 8 2018, 3:14 PM

mydeveloperday accepted this revision.Apr 9 2018, 10:07 AM

This revision is now accepted and ready to land.Apr 9 2018, 10:07 AM

Closed by commit rP0363febeb2c6: Disable default syntax highlighting for large files in DocumentEngine (authored by epriestley). · Explain WhyApr 9 2018, 11:47 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

document/

PhabricatorSourceDocumentEngine.php

21 lines

Diff 46196

View Options

src/applications/files/document/PhabricatorSourceDocumentEngine.php

Disable default syntax highlighting for large files in DocumentEngineClosedPublicActions