Page MenuHomePhabricator
Differential D19293

When a revision has more than 7 reviewers, render only the first 7 in the list view
ClosedPublic
Actions

Authored by epriestley on Apr 3 2018, 6:51 PM.
Tags
None
Referenced Files
F15480564: D19293.id46176.diff
Tue, Apr 8, 2:58 PM
F15466245: D19293.id46174.diff
Thu, Apr 3, 3:16 AM
F15465123: D19293.id.diff
Wed, Apr 2, 2:54 PM
F15461094: D19293.diff
Tue, Apr 1, 5:10 AM
F15459579: D19293.id.diff
Mon, Mar 31, 2:20 PM
F15432422: D19293.diff
Mon, Mar 24, 6:04 PM
F15427824: D19293.diff
Sun, Mar 23, 4:10 PM
F15415477: D19293.id46174.diff
Thu, Mar 20, 6:12 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions
Commits
rPe40aec0210dc: When a revision has more than 7 reviewers, render only the first 7 in the list…
Summary

See PHI489. Ref T13110. At least for now, this just shows "..." at the end since you can click the revision to see the whole list anyway.

Also remove the older-style external Handle passing in favor of lazy construction via HandlePool.

Test Plan

Viewed revisions, fiddled with the 7 limit, got sensible-seeming "..." behavior.

Diff Detail

Repository
rP Phabricator
Branch
size1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19995
Build 27110: Run Core Tests
Build 27109: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 3 2018, 6:51 PM
Harbormaster completed remote builds in B19995: Diff 46174.Apr 3 2018, 6:52 PM
epriestley requested review of this revision.Apr 3 2018, 6:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 7:47 PM
Closed by commit rPe40aec0210dc: When a revision has more than 7 reviewers, render only the first 7 in the list… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
12 lines
query/
18 lines
view/
84 lines
diffusion/
controller/
6 lines
people/
controller/
6 lines

Diff 46174

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionListView.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php

Loading...
Phabricator · Built by Phacility