Page MenuHomePhabricator
Differential D19277

Fix YouTube remarkup rule being blocked by Content-Security-Policy header
ClosedPublic
Actions

Authored by epriestley on Apr 2 2018, 11:05 PM.
Tags
None
Referenced Files
F15471191: D19277.id46142.diff
Sat, Apr 5, 4:04 AM
F15464822: D19277.id46142.diff
Wed, Apr 2, 12:52 PM
F15448141: D19277.id46143.diff
Fri, Mar 28, 3:19 AM
F15448140: D19277.id46142.diff
Fri, Mar 28, 3:18 AM
F15448139: D19277.id.diff
Fri, Mar 28, 3:18 AM
F15446667: D19277.diff
Thu, Mar 27, 7:42 PM
F15435045: D19277.diff
Tue, Mar 25, 6:38 AM
F15426823: D19277.id46142.diff
Sun, Mar 23, 10:57 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13116: Plans: 2018 Week 14 Bonus Content
Commits
rP651f91cd544c: Fix YouTube remarkup rule being blocked by Content-Security-Policy header
Summary

Ref T13116. See PHI526. Currently, the YouTube remarkup rule writes an <iframe ...> but does not adjust the Content-Security-Policy appropriately.

Test Plan

Pasted a YouTube link; viewed it in Safari, Chrome and Firefox.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 2 2018, 11:05 PM
Harbormaster failed remote builds in B19963: Diff 46142!Apr 2 2018, 11:06 PM
Harbormaster completed remote builds in B19963: Diff 46142.Apr 2 2018, 11:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 2 2018, 11:09 PM
epriestley requested review of this revision.
Closed by commit rP651f91cd544c: Fix YouTube remarkup rule being blocked by Content-Security-Policy header (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
markup/
rule/
5 lines

Diff 46143

View Options

src/infrastructure/markup/rule/PhabricatorYoutubeRemarkupRule.php

Loading...
Phabricator · Built by Phacility