Page MenuHomePhabricator
Differential D19277

Fix YouTube remarkup rule being blocked by Content-Security-Policy header
ClosedPublic
Actions

Authored by epriestley on Apr 2 2018, 11:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 5:47 AM
Unknown Object (File)
Sun, Feb 9, 5:47 AM
Unknown Object (File)
Sun, Feb 9, 5:47 AM
Unknown Object (File)
Sun, Feb 9, 5:47 AM
Unknown Object (File)
Fri, Jan 31, 6:00 PM
Unknown Object (File)
Sat, Jan 25, 2:52 AM
Unknown Object (File)
Sat, Jan 25, 12:53 AM
Unknown Object (File)
Sat, Jan 25, 12:53 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13116: Plans: 2018 Week 14 Bonus Content
Commits
rP651f91cd544c: Fix YouTube remarkup rule being blocked by Content-Security-Policy header
Summary

Ref T13116. See PHI526. Currently, the YouTube remarkup rule writes an <iframe ...> but does not adjust the Content-Security-Policy appropriately.

Test Plan

Pasted a YouTube link; viewed it in Safari, Chrome and Firefox.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 2 2018, 11:05 PM
Harbormaster failed remote builds in B19963: Diff 46142!Apr 2 2018, 11:06 PM
Harbormaster completed remote builds in B19963: Diff 46142.Apr 2 2018, 11:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 2 2018, 11:09 PM
epriestley requested review of this revision.
Closed by commit rP651f91cd544c: Fix YouTube remarkup rule being blocked by Content-Security-Policy header (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
markup/
rule/
5 lines

Diff 46143

View Options

src/infrastructure/markup/rule/PhabricatorYoutubeRemarkupRule.php

Loading...
Phabricator · Built by Phacility