Differential D19257

Drop uniqueness constraint on PushEvent request ID
ClosedPublic
Actions

Authored by epriestley on Mar 26 2018, 1:58 PM.

Tags

None

Referenced Files

	F15423703: D19257.id46102.diff
	Sat, Mar 22, 4:48 PM

	F15417663: D19257.diff
	Thu, Mar 20, 5:51 PM

	F15412646: D19257.diff
	Wed, Mar 19, 2:09 PM

	Unknown Object (File)
	Feb 16 2025, 4:20 AM

	Unknown Object (File)
	Jan 30 2025, 5:05 PM

	Unknown Object (File)
	Jan 27 2025, 1:27 AM

	Unknown Object (File)
	Jan 21 2025, 9:51 AM

	Unknown Object (File)
	Jan 12 2025, 12:12 PM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP5e710959bed9: (stable) Drop uniqueness constraint on PushEvent request ID
rPf583406ba93a: Drop uniqueness constraint on PushEvent request ID

Summary

See https://discourse.phabricator-community.org/t/pushing-to-mercurial-repository-fails/1275/1. Mercurial may invoke hooks multiple times per push.

Test Plan

Pushed to Mercurial, saw key constraint failure.

Diff Detail

Repository

rP Phabricator

Branch

req1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19921
Build 27003: Run Core Tests
Build 27002: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 26 2018, 1:58 PM

Harbormaster completed remote builds in B19921: Diff 46102.Mar 26 2018, 1:59 PM

epriestley requested review of this revision.Mar 26 2018, 1:59 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 26 2018, 2:02 PM

Closed by commit rPf583406ba93a: Drop uniqueness constraint on PushEvent request ID (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20180326.lock.03.nonunique.sql

2 lines

src/

applications/

repository/

storage/

PhabricatorRepositoryPushEvent.php

3 lines

Diff 46102

View Options

resources/sql/autopatches/20180326.lock.03.nonunique.sql