Page MenuHomePhabricator
Differential D19253

Add a very rough, proof-of-concept Jupyter notebook document engine
ClosedPublic
Actions

Authored by epriestley on Mar 23 2018, 2:06 PM.
Tags
None
Referenced Files
F14063855: D19253.diff
Mon, Nov 18, 8:37 PM
F14045795: D19253.diff
Wed, Nov 13, 11:35 AM
F14045674: D19253.diff
Wed, Nov 13, 8:05 AM
F14009705: D19253.id46095.diff
Wed, Oct 30, 10:59 PM
F14009703: D19253.id46092.diff
Wed, Oct 30, 10:59 PM
F14009702: D19253.id.diff
Wed, Oct 30, 10:59 PM
F14008345: D19253.diff
Tue, Oct 29, 7:38 PM
F13999819: D19253.id46095.diff
Thu, Oct 24, 5:24 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits
rPcbf3d3c37154: Add a very rough, proof-of-concept Jupyter notebook document engine
Summary

Depends on D19252. Ref T13105. This very roughly renders Jupyter notebooks.

It's probably better than showing the raw JSON, but not by much.

Test Plan
  • Viewed various notebooks with various cell types, including markdown, code, stdout, stderr, images, HTML, and Javascript.
  • HTML and Javascript are not live-fired since they're wildly dangerous.

Diff Detail

Repository
rP Phabricator
Branch
docu3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19910
Build 26988: Run Core Tests
Build 26987: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 23 2018, 2:06 PM
Harbormaster completed remote builds in B19910: Diff 46092.Mar 23 2018, 2:07 PM
epriestley requested review of this revision.Mar 23 2018, 2:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 23 2018, 2:14 PM
Closed by commit rPcbf3d3c37154: Add a very rough, proof-of-concept Jupyter notebook document engine (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
2 lines
applications/
files/
document/
9 lines
305 lines
webroot/
rsrc/
css/
phui/
47 lines

Diff 46092

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/document/PhabricatorDocumentRef.php

Loading...
View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
Phabricator · Built by Phacility