Paths

Table of Contentst

Differential D19235

Give all commands from DiffusionCommandEngine a default 15 minute timeout
ClosedPublic
Actions

Authored by epriestley on Mar 17 2018, 12:15 AM.

Tags

None

Referenced Files

	F15497309: D19235.id46058.diff
	Sun, Apr 13, 10:17 AM

	F15497307: D19235.id.diff
	Sun, Apr 13, 10:17 AM

	F15497140: D19235.id46057.diff
	Sun, Apr 13, 9:55 AM

	F15455171: D19235.id46058.diff
	Sat, Mar 29, 10:37 PM

	F15449015: D19235.id46057.diff
	Fri, Mar 28, 8:11 AM

	F15446166: D19235.id.diff
	Thu, Mar 27, 5:27 PM

	F15442132: D19235.diff
	Wed, Mar 26, 9:42 PM

	F15401963: D19235.diff
	Mon, Mar 17, 7:56 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13108: Plans: 2018 Week 12 Bonus Content
Commits: rP7e43b7405512: Give all commands from DiffusionCommandEngine a default 15 minute timeout

Summary

Ref T13108. See PHI364. See the task and issue for discussion.

If a git fetch during synchronization hangs, the whole node currently hangs. While the causes of a git fetch hang aren't clear, we don't expect synchronization to ever reasonably take more than 15 minutes, so add a default timeout.

Test Plan

Will deploy and observe; this is difficult to reproduce or test directly.

Diff Detail

Repository

rP Phabricator

Branch

timeout1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19876
Build 26936: Run Core Tests
Build 26935: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 17 2018, 12:15 AM

Harbormaster completed remote builds in B19876: Diff 46057.Mar 17 2018, 12:16 AM

epriestley requested review of this revision.Mar 17 2018, 12:16 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2018, 12:22 AM

Closed by commit rP7e43b7405512: Give all commands from DiffusionCommandEngine a default 15 minute timeout (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

protocol/

DiffusionCommandEngine.php

5 lines

Diff 46057

View Options

src/applications/diffusion/protocol/DiffusionCommandEngine.php

Give all commands from DiffusionCommandEngine a default 15 minute timeoutClosedPublicActions